Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLIP: Update pat-select2 to latest select2 in Plone 7 #16

Open
petschki opened this issue Jul 18, 2024 · 1 comment
Open

PLIP: Update pat-select2 to latest select2 in Plone 7 #16

petschki opened this issue Jul 18, 2024 · 1 comment
Labels
03 type: feature (plip) really new stuff or major change
Milestone

Comments

@petschki
Copy link
Member

PLIP (Plone Improvement Proposal)

Responsible Persons

Proposer: Peter M. / petschki

Seconder: add your name here

Abstract

pat-select2 depends on an old and customized version of select2. Lets either

  • update it to the latest version of select2 and get rid of the customizations.
  • or create a new pattern with the latest version and deprecate the old one.

Motivation

Keep the Classic-UI stack up to date.

Proposal & Implementation

There are two possible implementations:

  1. update pat-select2 to the latest select2 version and document the API changes.
  2. create a new pattern pat-select which uses the latest version of select2 and remove pat-select2 with documentation how to migrate to the new pattern.

Deliverables

I've started upgrading pat-select2 here a while ago (plone/mockup#1295) but depending on the discussion here its maybe better to start off with a new pattern for the new version.

Risks

case 1: updateing pat-select2 -> the select2 API changes radically and addons will not work anymore.
case 2: adding new pattern: addons will also have to migrate their code to the new api

Participants

  • petschki
  • add your name here

@plone/classicui-team

@petschki petschki added the 03 type: feature (plip) really new stuff or major change label Jul 18, 2024
@petschki petschki added this to the Plone 7.0 milestone Jul 18, 2024
@MrTango
Copy link
Contributor

MrTango commented Nov 5, 2024

+1, this could event be done before 7.x, if the patter does not change it's behavior to the outside.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
03 type: feature (plip) really new stuff or major change
Projects
None yet
Development

No branches or pull requests

2 participants