Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix temporary rendering of folder contents while query is loading #4936

Merged
merged 2 commits into from
Jul 6, 2023
Merged

Fix temporary rendering of folder contents while query is loading #4936

merged 2 commits into from
Jul 6, 2023

Conversation

davisagli
Copy link
Member

Fixes #4351

@netlify
Copy link

netlify bot commented Jun 29, 2023 •
edited
Loading

✅ Deploy Preview for volto canceled.

Name Link
🔨 Latest commit fd21647
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/649dbc4ddfe950000808d536

@cypress
Copy link

cypress bot commented Jun 29, 2023

Passing run #6011 ↗︎

0 511 20 0 Flakiness 0

Details:

changelog
Project: Volto Commit: fd21647ccc
Status: Passed Duration: 19:15 💡
Started: Jun 29, 2023 5:18 PM Ended: Jun 29, 2023 5:37 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

wesleybl
wesleybl approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@wesleybl wesleybl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sneridagh sneridagh merged commit 5b67de2 into master Jul 6, 2023
@sneridagh sneridagh deleted the fix-contents-while-query-loads branch July 6, 2023 08:25
sneridagh pushed a commit that referenced this pull request Jul 6, 2023
@davisagli @sneridagh
Fix temporary rendering of folder contents while query is loading (#4936
93bc0c0 
)
sneridagh added a commit that referenced this pull request Jul 6, 2023
@sneridagh @davisagli
Fix temporary rendering of folder contents while query is loading (#4936
b311b51 
) (#4950)

Co-authored-by: David Glick <david@glicksoftware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleybl wesleybl wesleybl approved these changes

@sneridagh sneridagh sneridagh approved these changes

@tiberiuichim tiberiuichim Awaiting requested review from tiberiuichim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Listing block should never be passed folder contents, if it has a query
3 participants
@davisagli @sneridagh @wesleybl