-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate screenshots for our demos + requirements.lock.txt
#131
Comments
we did a lot of moving in the examples recently. if you find anything that's weird, please open an issue (e.g., broken links from the documentation to the examples) @neelasha23 |
where do we need to store the screenshots? In the same folder as each project? Or some common folder for all projects? @edublancas |
Added a couple of samples: #134 |
The w/h proportion is approximately 1.9, but there is no specific recommended resolution. Below are some images I used in development: Both of them look nice |
thanks @yafimvo @neelasha23 I'll give you access to the /explore page (we'll use the screenshots there as well) so you can test sizes opengraph recommends:
so let's start with that. we also need to ensure the images are small so they load fast. I think webp is a good candiate. @neelasha23 expect a message from me on slack |
1200 x 630: 1400 x 673: I think the 1st one is not that good and we should go for a bit higher resolution? @edublancas |
Also, do we need to add all example to the explore page? That means we need to keep the applications deployed? Any specific account in which to deploy? @edublancas |
re resolution: yeah, you can experiment a bit and decide which resolution and aspect ratio is best. also, you might wanna zoom in using the browser so the text is more readable re deployments: good point. I think for now, let's link to the source code in this repository. example I also realized that some of our apps are APIs (no UI), in that case, we can create an image with the framework's logo (flask, fastapi, etc) |
@neelasha23 what's the status? please open small PRs, don't wait to have all screenshots |
The thumbnails were not coming up in explore page. The fix was got deployed. The images that I generate are a bit small for the thumbnail. I'll just resize the images and update the PR |
I think the
|
@yafimvo @idomic can we remove this URL validation. some of our examples are not deployed anymore and we want to link to the README.md, we might decide to deploy them at some point but right now it'd be easier to just link to the readme @neelasha23 please work on #139 (and the other assigned issues) until we unblock this |
Also, webp is not supported. so adding png files as of now
|
ok, let's do another format then |
Yes, in this case, I need to add one more parameter -
As for the default images, I can create a mechanism that if there is no image we can show the framework logo.
yes, the padding is part of the design. why do we want to reduce it? As part of this PR I'll also add webp support. If you think I should include anything else please let me know. |
The text would look a bit clearer and bigger if we reduce a bit of the padding. wdyt @edublancas |
@neelasha23 It won't make the difference The issue is that the image has a lot of details in it, and that's why the text will always look "small". we can show a smaller part of the app, for example this is the image |
why is a new parameter needed?
sounds good
I think the padding is fine
sounds good |
|
we can come back to those later if needed. are those the only ones left? |
yes i have added all the rest @edublancas |
Did you add them to the zip files too? When I did some check on Friday I didn't see either |
No I didn't add the lock files to the zip as it was not in the scope of the issue. Please refer to this comment @idomic |
we're not adding .zip for all examples, we only add them for the ones used in the frontend |
we have a new explore page where we'll showcase our examples
we need to generate one image per demo, no need to have them all at once, we can generate a batch and open a PR
also, no need to deploy them, we can run them locally and take the screenshot
since some examples might not work due to library API changes, we might need to update the code or downgrade versions, whatever is easier on each case, once we get them working, we should record the versions with
pip freeze > requirements.lock.txt
The text was updated successfully, but these errors were encountered: