Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Incident - deprecation warning incorrectly displayed #213

Conversation

tonykploomber
Copy link

@tonykploomber tonykploomber commented Mar 4, 2023

Describe your changes

Fix the bug - deprecation warning incorrectly displayed

Originally, we have the custom variable substitution, but it will also handle the connection string like this, which we have the regex to detect if it's contains :variable, it will detect connection string as variable substitution case.

Connection string:
mysql+mysqldb://user:password@127.0.0.1:3306/db

(:password was treat as variable)

Fix by executing the _var_expand after the command is parsed by parse.parse(), so it would not contain connecting string anymore

Issue ticket number and link

Closes #203

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added thorough tests (when necessary).
  • I have added the right documentation in the docstring and changelog (when needed)

📚 Documentation preview 📚: https://jupysql--213.org.readthedocs.build/en/213/

@tonykploomber tonykploomber linked an issue Mar 4, 2023 that may be closed by this pull request
@tonykploomber tonykploomber marked this pull request as draft March 4, 2023 20:38
@tonykploomber tonykploomber requested a review from edublancas March 4, 2023 20:56
@tonykploomber tonykploomber marked this pull request as ready for review March 4, 2023 20:56
@edublancas edublancas merged commit 5752ceb into ploomber:master Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecation warning incorrectly displayed
2 participants