fixing problems with comments that have % and fixing incompatibility with MySQL
#362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edublancas
force-pushed
the
plot-backticks
branch
from
997e8e0
to
357cded
Compare
edublancas
force-pushed
the
plot-backticks
branch
from
a847958
to
2a399ab
Compare
edublancas
changed the title
% and fixing incompatibility with MySQL
yafimvo
approved these changes
Apr 5, 2023
There was a problem hiding this comment.
lgtm.
Tested locally these code cells and it works:
%%sql --save many_passengers --no-execute
SELECT *
FROM taxi
WHERE passenger_count > 3
-- remove top 1% outliers for better visualization
AND trip_distance < 18.93
Returns a table
%sql --with many_passengers select * from many_passengers limit 2
Returns a plot
%sqlplot histogram --table many_passengers --column trip_distance --with many_passengers
| ) | ||
|
|
||
| if use_backticks: | ||
| template_ = template_.replace('"', "`") |
There was a problem hiding this comment.
I think in the future we can make it dynamic because there might be exceptional DBs, and we don't want to have to pass use_backticks and check it every time we run a query.
There was a problem hiding this comment.
I'm passing it depending on the dialect type, but yes, we need to come up with a more reliable way
idomic
approved these changes
Apr 5, 2023
| @@ -482,9 +486,13 @@ def _histogram(table, column, bins, with_=None, conn=None, facet=None): | |||
| """Compute bins and heights""" | |||
| if not conn: | |||
| conn = sql.connection.Connection.current.session | |||
| use_backticks = sql.connection.Connection.is_use_backtick_template() | |||
| else: | |||
| # TODO: fix | |||
|
I think I have a lot similar fix in https://github.com/ploomber/jupysql/pull/339/files But LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR fixes several problems:
"and backticks depending on the dialecttextobjects to theexecutemethod to prevent SQLAlchemy from interpreting stuff like%nameas query parameterIssue number
Closes #X
Checklist before requesting a review
pkgmt format📚 Documentation preview 📚: https://jupysql--362.org.readthedocs.build/en/362/