Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlcmd profile improvements #459

Closed
idomic opened this issue Apr 26, 2023 · 5 comments · Fixed by #616
Closed

sqlcmd profile improvements #459

idomic opened this issue Apr 26, 2023 · 5 comments · Fixed by #616
Assignees
Labels
stash Label used to categorize issues that will be worked on next

Comments

@idomic
Copy link

idomic commented Apr 26, 2023

So the table profiling is a bit unclear on how to read the output and what to do with nan values.
For instance, running on the table below, it could be nan for many reasons, wrong datatypes, db doesn't support the unique functions (STDEV function), confusing values (2.456e+01) etc.

We should improve the guide and the functionality of it, and produce a result that's similar in essence to the pandas profiling report.
Screen Shot 2023-04-26 at 3 57 46 PM

@edublancas feel free to add more context.

@edublancas
Copy link

I think we should diagnose first why we have some many nans, and then decide what's the best way to replace them. For example, if the table doesn't have the STDEV function, perhaps we can show another string or change the color - this is the only case where the behavior should differ from pandas.

For the other cases, we should look at how pandas handles it.

@edublancas edublancas added stash Label used to categorize issues that will be worked on next med complexity labels May 23, 2023
@edublancas
Copy link

hey @yafimvo: did you start working on this? I can assign it to somebody else

@yafimvo
Copy link

yafimvo commented Jun 7, 2023

@edublancas No

@edublancas
Copy link

cool. I'll assign it to someone else.

@edublancas edublancas assigned AnirudhVIyer and unassigned yafimvo Jun 7, 2023
@AnirudhVIyer
Copy link

On it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stash Label used to categorize issues that will be worked on next
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants