-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Devcontainer support #484
Devcontainer support #484
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please also add a changelog entry (with your handle), and some documentation on how to use it here?
@idomic These work without problems for me (runs, exit code 0, no output, no errors): ❯ conda activate jupysql
❯ python examples/plot_boxplot.py
❯ python /workspaces/jupysql/examples/plot_boxplot.py
❯ python -c "from sql.connection import Connection" Note that you shouldn’t use ❯ which python
/opt/conda/envs/jupysql/bin/python
# Note that python does NOT point to /opt/conda/bin/python Both the last 2 |
doc/community/developer-guide.md
Outdated
![JupySQL github codespace](../static/github-codespace.png) | ||
You can launch a new github codespace from the green "Code" button on [the JupySQL github repository](https://github.com/ploomber/jupysql). | ||
|
||
After the codespace has finished setting up, you can run `conda activate jupysql` to activate the JupySQL Conda environment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've never used codespaces so I'm unfamiliar with the details but let's add some basic tips.
I looked at the pricing and github gives 60 hours monthly for free, but it looks like we have to manually stop it to prevent from going over - so let's add a note on this
is there anything else that's important for people to know?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
relevant link: https://github.com/codespaces - allows managing codespaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codespaces by default will shut down after 30 min of idle time. I will add a note on this and link to the codespace docs and pricing.
Allows contributors to get up and running quickly using github codespaces.
f74c732
to
3985a5f
Compare
@edublancas updated the docs based on your comments, but running into an issue with |
Great, thanks! |
Allows contributors to get up and running quickly
using github codespaces.
Checklist before requesting a review
pkgmt format
-> NA📚 Documentation preview 📚: https://jupysql--484.org.readthedocs.build/en/484/