Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checking custom connections according to PEP 249 #517

Merged
merged 10 commits into from
May 29, 2023

Conversation

mehtamohit013
Copy link

@mehtamohit013 mehtamohit013 commented May 25, 2023

Describe your changes

Added PEP 249 compliance to custom connection.
Checking whether the connection object has close, commit and rollback methods

Issue number

Closes #433

Checklist before requesting a review


📚 Documentation preview 📚: https://jupysql--517.org.readthedocs.build/en/517/

@mehtamohit013 mehtamohit013 changed the title Conn PEP 249 Compliant Custom Connection May 25, 2023
@mehtamohit013 mehtamohit013 marked this pull request as ready for review May 25, 2023 17:28
Copy link

@edublancas edublancas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add some tests?

also, please check that the problem I reported is also fixed

@mehtamohit013
Copy link
Author

@edublancas
Yup, it is working as expected

Code cell:

%load_ext sql
%sql duckdb://
df = 1
%sql --persist df

pep

@mehtamohit013 mehtamohit013 requested a review from edublancas May 25, 2023 22:01
src/tests/test_connection.py Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link

@tonykploomber tonykploomber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor

src/sql/connection.py Outdated Show resolved Hide resolved
mehtamohit013 and others added 5 commits May 26, 2023 15:01
Co-authored-by: Eduardo Blancas <edu.blancas@gmail.com>
Co-authored-by: Tony Kuo <123580782+tonykploomber@users.noreply.github.com>
@edublancas edublancas changed the title PEP 249 Compliant Custom Connection checking custom connections according to PEP 249 May 29, 2023
@edublancas edublancas merged commit aee9eee into ploomber:master May 29, 2023
@mehtamohit013 mehtamohit013 deleted the conn branch June 9, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error when detecting is connection is custom
3 participants