Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make toml optional #825

Closed
edublancas opened this issue Aug 23, 2023 · 2 comments · Fixed by #831
Closed

make toml optional #825

edublancas opened this issue Aug 23, 2023 · 2 comments · Fixed by #831
Assignees

Comments

@edublancas
Copy link

What happens?

if there is a pyproject.toml file but the toml package isn't installed. initializing jupysql fails:

[... long traceback]

ModuleNotFoundError: 'toml' is required to use 'load_toml'. Install with: pip install 'toml'

Instead we should display a message saying that a pyproject.toml was found but that the toml dependency isn't installed.so if the user wants to load the settings, they must install the toml package

To Reproduce

create pyproject.toml and start the extension, ensure the toml package is not installed

OS:

macOS

JupySQL Version:

0.10.0dev

Full Name:

Eduardo Blancas

Affiliation:

Ploomber

@bbeat2782
Copy link

bbeat2782 commented Aug 24, 2023

Acceptance Criteria

  1. If pyproject.toml file is found but the toml package isn't installed, a message should show up instead of the ModuleNotFoundError.
  2. Add test function

@edublancas
Copy link
Author

go ahead!

This was referenced Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants