right bracket was added after comment line if the last line of a CTE is comment

[santasatan]

What happens?

when use --save to write a query and it is happened that a comment line is added as the last line of the query, then if this query is used as a CTE (--with) in latter cell, the right bracket of the CTE query is added at the end of the comment line, which cause the program ignores the bracket when run the query and cause error

To Reproduce

cell 1

%%sql --save q1 --no-execute
select *
from xx
--thi is comment

cell 2

%%sql --with q1
select *
from t1, xx
where t1.id = xx.id 

then, when run cell 2, it seems the whole query will be translated to this and will get error

WITH q1 AS (
select *
from xx
--this is comment )                 *--here the bracket is added at the end of the comment line

select *
from t1, xx
where t1.id = xx.id 

OS:

Windows

JupySQL Version:

0.10.1

Full Name:

Santa Satan

Affiliation:

santa-satan

[edublancas]

this indeed looks like a bug. @neelasha23 please take a look

[edublancas]

@santasatan: this has been fixed in #894; I'd appreciate it if you could install jupysql from the main branch and test. If all is good, we'll release this!