-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Oracle Database Free #943
Conversation
Signed-off-by: Gerald Venzl <gerald.venzl@gmail.com>
The CI is failing. Please add a |
@neelasha23 in the meantime, can you run the tutorial to see everything works? |
We need to also modify the service name to
and
Otherwise it works @edublancas |
Signed-off-by: Gerald Venzl <gerald.venzl@gmail.com>
Signed-off-by: Gerald Venzl <gerald.venzl@gmail.com>
Hi @edublancas, hi @neelasha23, Thanks a lot for considering this PR! I'm sorry that I somehow missed the updated service name and the changelog entry. Thanks, |
No issues. Looks good now! |
Awesome, great to hear, thanks @neelasha23! |
thanks for your contribution, @gvenzl! |
My pleasure! Thanks for merging it! :) |
Describe your changes
Hi all,
This PR is a minor change upgrading the Oracle Database docker image from gvenzl/oracle-xe to the successor image gvenzl/oracle-free.
Issue number
N/A
Checklist before requesting a review
Formatted my code withpkgmt format
Added tests (when necessary).📚 Documentation preview 📚: https://jupysql--943.org.readthedocs.build/en/943/