Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Oracle Database Free #943

Merged
merged 4 commits into from
Nov 20, 2023
Merged

Upgrade to Oracle Database Free #943

merged 4 commits into from
Nov 20, 2023

Conversation

gvenzl
Copy link

@gvenzl gvenzl commented Nov 17, 2023

Describe your changes

Hi all,

This PR is a minor change upgrading the Oracle Database docker image from gvenzl/oracle-xe to the successor image gvenzl/oracle-free.

Issue number

N/A

Checklist before requesting a review


📚 Documentation preview 📚: https://jupysql--943.org.readthedocs.build/en/943/

Signed-off-by: Gerald Venzl <gerald.venzl@gmail.com>
@neelasha23
Copy link

neelasha23 commented Nov 17, 2023

The CI is failing. Please add a Doc entry to the changelog and push the changes @gvenzl

@edublancas
Copy link

@neelasha23 in the meantime, can you run the tutorial to see everything works?

@neelasha23
Copy link

We need to also modify the service name to FREEPDB1 at two places in the notebook:

engine = create_engine(
    "oracle+oracledb://ploomber_app:ploomber_app_password@localhost:1521/?service_name=FREEPDB1"  # noqa: E501
)

and

%sql oracle+oracledb://ploomber_app:ploomber_app_password@localhost:1521/?service_name=FREEPDB1

@gvenzl

Otherwise it works @edublancas

Signed-off-by: Gerald Venzl <gerald.venzl@gmail.com>
Signed-off-by: Gerald Venzl <gerald.venzl@gmail.com>
@gvenzl
Copy link
Author

gvenzl commented Nov 18, 2023

Hi @edublancas, hi @neelasha23,

Thanks a lot for considering this PR!

I'm sorry that I somehow missed the updated service name and the changelog entry.
I have added both as requested and pushed to this PR again.

Thanks,

@neelasha23
Copy link

I'm sorry that I somehow missed the updated service name and the changelog entry. I have added both as requested and pushed to this PR again.

No issues. Looks good now!

@gvenzl
Copy link
Author

gvenzl commented Nov 18, 2023

Awesome, great to hear, thanks @neelasha23!

@edublancas edublancas merged commit e5f5ceb into ploomber:master Nov 20, 2023
23 checks passed
@edublancas
Copy link

thanks for your contribution, @gvenzl!

@gvenzl
Copy link
Author

gvenzl commented Nov 20, 2023

My pleasure! Thanks for merging it! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants