Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzzy matching should be used only for config keys, not sections #975

Closed
maciejb opened this issue Jan 3, 2024 · 0 comments · Fixed by #976
Closed

Fuzzy matching should be used only for config keys, not sections #975

maciejb opened this issue Jan 3, 2024 · 0 comments · Fixed by #976

Comments

@maciejb
Copy link

maciejb commented Jan 3, 2024

What happens?

Since we are only looking to read conifiguration [tool.jupysql.SqlMagic], it is not appropriate to be evaluating the validity of other sections in pyproject.toml, which may be perfectly valid but intended for other purposes

This implementation is responsible for part of the problem observed in #969

Creating a new issue as per #969 (comment) from @edublancas

To Reproduce

  1. Ensure [tool.jupysql.SqlMagic] is not present in either pyproject.toml or ~/.jupysql/config
  2. Add [tool.jupysqX.whatever] to one of these files
  3. Load the extension in ipython
  4. Observe the message:
In [1]: %load_ext sql
UsageError: 'jupysqX' is an invalid section name in [...]/pyproject.toml. Did you mean 'jupysql'?

OS:

Any

JupySQL Version:

0.10.7

Full Name:

Maciej Bukczynski

Affiliation:

Darkhorse Analytics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant