Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

Merged column name edits + hidden columns edge case #585

Open
alexcjohnson opened this issue Sep 13, 2019 · 0 comments
Open

Merged column name edits + hidden columns edge case #585

alexcjohnson opened this issue Sep 13, 2019 · 0 comments
Labels
dash-type-bug Something isn't working as intended Status: Discussion Needed Impacts or is impacted by other issues / parts of the system. Coordination needed.

Comments

@alexcjohnson
Copy link
Collaborator

After #578 fixes editing column names in the presence of hidden columns, there's a funny edge case that results:

From one perspective this is a bug: you started with a single header and you edited it, that name should apply to everything the original one applied to. Note that if the hidden column was also named A, all three of them would have been renamed to C, so the editing action depends on invisible properties.

From another perspective, the full table is the authority, and if it doesn't consider the first and third column headers to be merged then why should the edit operation? If we take that perspective, perhaps the real bug is that the two As merged into one header in the first place. They're not adjacent in the full table, so they should not be considered mergeable, regardless of whether the column between them is visible.

@alexcjohnson alexcjohnson added dash-type-bug Something isn't working as intended Status: Discussion Needed Impacts or is impacted by other issues / parts of the system. Coordination needed. labels Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dash-type-bug Something isn't working as intended Status: Discussion Needed Impacts or is impacted by other issues / parts of the system. Coordination needed.
Projects
None yet
Development

No branches or pull requests

1 participant