This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
Merged column name edits + hidden columns edge case #585
Labels
dash-type-bug
Something isn't working as intended
Status: Discussion Needed
Impacts or is impacted by other issues / parts of the system. Coordination needed.
After #578 fixes editing column names in the presence of hidden columns, there's a funny edge case that results:
A
,B
,A
B
-> now the first row headers merge into a singleA
A
toC
C
; the other one is stillA
, so they cease to be merged. This is because when renaming we consider all the columns, not just the visible ones, and in that context these cells actually aren't merged.From one perspective this is a bug: you started with a single header and you edited it, that name should apply to everything the original one applied to. Note that if the hidden column was also named
A
, all three of them would have been renamed toC
, so the editing action depends on invisible properties.From another perspective, the full table is the authority, and if it doesn't consider the first and third column headers to be merged then why should the edit operation? If we take that perspective, perhaps the real bug is that the two
A
s merged into one header in the first place. They're not adjacent in the full table, so they should not be considered mergeable, regardless of whether the column between them is visible.The text was updated successfully, but these errors were encountered: