Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

Incorrect cell validation / coercion #600

Closed
Marc-Andre-Rivet opened this issue Sep 24, 2019 · 0 comments · Fixed by #601
Closed

Incorrect cell validation / coercion #600

Marc-Andre-Rivet opened this issue Sep 24, 2019 · 0 comments · Fixed by #601
Assignees
Labels
dash-type-bug Something isn't working as intended size: 0.5
Milestone

Comments

@Marc-Andre-Rivet
Copy link
Contributor

1 - Validation default is not applied correctly when its value is 0 (number) -- the value is falsy and trips the default case
2 - Deleting cell content with backspace does not run validation

1 - This is simple, update https://github.com/plotly/dash-table/blob/dev/src/dash-table/type/reconcile.ts#L67 to do a R.isNil check instead

2 - This is a bit more involved, I suggest that we start using the on_change settings applicable to each cell and use the reconciliation result of null if the reconciliation is successful. Otherwise, continue using '' as we do right now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dash-type-bug Something isn't working as intended size: 0.5
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant