Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

Can't navigate with keyboard through non-editable cells #618

Closed
Marc-Andre-Rivet opened this issue Oct 8, 2019 · 1 comment · Fixed by #620
Closed

Can't navigate with keyboard through non-editable cells #618

Marc-Andre-Rivet opened this issue Oct 8, 2019 · 1 comment · Fixed by #620
Assignees
Labels
dash-type-bug Something isn't working as intended regression Worked in a previous version size: 1
Milestone

Comments

@Marc-Andre-Rivet
Copy link
Contributor

Marc-Andre-Rivet commented Oct 8, 2019

Using the standalone app (for simplicity, will be the same with callbacks).
Not sure when this regression appeared, probably <=1.0.0.

Modify eee and fff columns in data.ts with

editable: false

Navigating with the keyboard, upon reaching columns eee or fff, won't be able to move from the cell afterwards.

@Marc-Andre-Rivet Marc-Andre-Rivet added dash-type-bug Something isn't working as intended regression Worked in a previous version size: 1 labels Oct 8, 2019
@Marc-Andre-Rivet Marc-Andre-Rivet added this to the Dash v1.5.0 milestone Oct 8, 2019
@Marc-Andre-Rivet
Copy link
Contributor Author

Reproducing this turned out to be a little more subtle than just making the entire table readonly. The problem arises when the navigation goes through an editable cell.

If all cells are readonly, the initial mouse click will set the focus on some <td> and it will remain there through keyboard navigations.

If rows are not all readonly, keyboard navigation will eventually be on an editable cell and the focus will change to be on an input. When the focus changes to another editable cell there's no problem: the focus is moved to the new input, but if a readonly cell is selected, there is no focused element. Making it impossible to move the selection through the keyboard anymore.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dash-type-bug Something isn't working as intended regression Worked in a previous version size: 1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant