Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] tabIndex of Div should also accept number type #2891

Closed
CNFeffery opened this issue Jun 18, 2024 · 2 comments · Fixed by #2896
Closed

[Feature Request] tabIndex of Div should also accept number type #2891

CNFeffery opened this issue Jun 18, 2024 · 2 comments · Fixed by #2896
Labels
good first issue suitable for newcomers

Comments

@CNFeffery
Copy link
Contributor

In the origin React, parameter tabIndex could accept number type:
image

It would be better to add number type support for tabIndex:

image
@CNFeffery
Copy link
Contributor Author

CNFeffery commented Jun 18, 2024 •
edited
Loading

For example, when using other React libraries like react-slick to develop Dash component, its inner logic will change tabIndex to -1, which causes a type check error to be triggered in Dash(2.17.1):

image

image

@AnnMarieW
Copy link
Collaborator

It may be possible to fix this just by including 'tabIndex' here: https://github.com/plotly/dash/blob/dev/components/dash-html-components/scripts/generate-components.js#L59

@AnnMarieW AnnMarieW added the good first issue suitable for newcomers label Jun 20, 2024
@insistence insistence mentioned this issue Jun 21, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue suitable for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

The tabIndex parameter of Div can accept number or string type insistence/dash
2 participants
@CNFeffery @AnnMarieW