Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert 2126 until fixed #2168

Merged
merged 3 commits into from
Aug 1, 2022
Merged

revert 2126 until fixed #2168

merged 3 commits into from
Aug 1, 2022

Conversation

AnnMarieW
Copy link
Collaborator

@AnnMarieW AnnMarieW commented Jul 25, 2022 •
edited
Loading

Two new bugs were introduced in #2126

  1. Breaks dash-auth as reported here
  2. At times, the app will not load initially until after the browser is refreshed.
    image

This PR reverts 2126

alexcjohnson
alexcjohnson reviewed Jul 28, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
alexcjohnson
alexcjohnson approved these changes Jul 28, 2022
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Certainly odd symptoms - it's going to be tricky to figure out how to test this when we do figure out a better way to enable this. Looks good once tests pass and you consider my changelog suggestions.

@AnnMarieW @alexcjohnson
Update CHANGELOG.md
982d7d1 
Co-authored-by: Alex Johnson <alex@plot.ly>
@ned2 ned2 mentioned this pull request Jul 30, 2022
Closed
@alexcjohnson alexcjohnson merged commit 313857e into plotly:dev Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnnMarieW @alexcjohnson