Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inserted dynamic ids in component as props. #2336

Merged
merged 5 commits into from
Dec 5, 2022
Merged

Fix inserted dynamic ids in component as props. #2336

merged 5 commits into from
Dec 5, 2022

Conversation

T4rk1n
Copy link
Contributor

@T4rk1n T4rk1n commented Nov 23, 2022

Fix #2296

alexcjohnson
alexcjohnson approved these changes Dec 1, 2022
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, and beautiful test - just one small comment then 💃

T4rk1n and others added 2 commits December 5, 2022 11:26
@T4rk1n @alexcjohnson
Update tests/integration/renderer/test_component_as_prop.py
7cf40cc 
make sure the nth button click was really the reason the nth span changed from empty to "1"

Co-authored-by: Alex Johnson <johnson.alex.c@gmail.com>
@T4rk1n
Merge branch 'dev' into fix-2296
c547765 
# Conflicts:
#	CHANGELOG.md
@T4rk1n T4rk1n merged commit f096e1a into dev Dec 5, 2022
@T4rk1n T4rk1n deleted the fix-2296 branch December 5, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Component as Props inserted by callbacks not found with dynamic inputs/outputs callbacks.
2 participants
@T4rk1n @alexcjohnson