Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This data makes the surface algorithm blow up #179

Closed
etpinard opened this issue Jan 13, 2016 · 3 comments
Closed

This data makes the surface algorithm blow up #179

etpinard opened this issue Jan 13, 2016 · 3 comments
Labels
bug something broken

Comments

@etpinard
Copy link
Contributor

... and freeze the browser tab.

z =  [[9607345622458638.0, 9607345622458652.0, 9607345622458652.0, 9607345622458646.0, 9607345622458652.0, 9607345622458650.0, 9607345622458650.0, 9607345622458646.0], [9607345622458654.0, 9607345622458640.0, 9607345622458650.0, 9607345622458652.0, 9607345622458652.0, 9607345622458654.0, 9607345622458650.0, 9607345622458652.0], [9607345622458654.0, 9607345622458652.0, 9607345622458638.0, 9607345622458652.0, 9607345622458650.0, 9607345622458652.0, 9607345622458654.0, 9607345622458650.0], [9607345622458650.0, 9607345622458652.0, 9607345622458650.0, 9607345622458632.0, 9607345622458644.0, 9607345622458646.0, 9607345622458646.0, 9607345622458650.0], [9607345622458654.0, 9607345622458652.0, 9607345622458650.0, 9607345622458650.0, 9607345622458638.0, 9607345622458654.0, 9607345622458654.0, 9607345622458650.0], [9607345622458650.0, 9607345622458654.0, 9607345622458650.0, 9607345622458646.0, 9607345622458652.0, 9607345622458638.0, 9607345622458646.0, 9607345622458652.0], [9607345622458654.0, 9607345622458652.0, 9607345622458654.0, 9607345622458650.0, 9607345622458654.0, 9607345622458652.0, 9607345622458640.0, 9607345622458654.0], [9607345622458650.0, 9607345622458652.0, 9607345622458650.0, 9607345622458652.0, 9607345622458650.0, 9607345622458654.0, 9607345622458654.0, 9607345622458638.0]]

most likely due to unstable floating point errors.

If that's the case, we should at least warn user when this happens.

@etpinard etpinard added the bug something broken label Jan 13, 2016
@alexcjohnson
Copy link
Collaborator

#1906 fixes this for SVG, but there's something strange still happening with webGL - the browser still locks up with an unending cascade of these errors:
screen shot 2017-07-21 at 4 56 06 pm

@alexcjohnson alexcjohnson changed the title This data makes the heatmap and surface algorithms blow up This data makes the surface algorithm blow up May 22, 2018
@archmoj archmoj self-assigned this Nov 27, 2018
@archmoj
Copy link
Contributor

archmoj commented Nov 27, 2018

A demo to illustrate the issue.

@archmoj archmoj mentioned this issue Nov 30, 2018
@archmoj archmoj removed their assignment Mar 3, 2020
@gvwilson
Copy link
Contributor

gvwilson commented Jun 5, 2024

Hi - this issue has been sitting for a while, so as part of our effort to tidy up our public repositories I'm going to close it. If it's still a concern, we'd be grateful if you could open a new issue (with a short reproducible example if appropriate) so that we can add it to our stack. Cheers - @gvwilson

@gvwilson gvwilson closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

No branches or pull requests

4 participants