Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical modebars break plots on IE11 #3489

Closed
wbrgss opened this issue Jan 28, 2019 · 4 comments
Closed

Vertical modebars break plots on IE11 #3489

wbrgss opened this issue Jan 28, 2019 · 4 comments
Labels
bug something broken

Comments

@wbrgss
Copy link
Contributor

wbrgss commented Jan 28, 2019

On IE11, setting the layout parameter modebar: {'orientation': 'v'} will break plots on IE11, with the following error:

Unhandled promise rejection TypeError: Object doesn't support property or method 'prepend'

This is likely related to this line in #3068 using element.prepend(). The bug can likely be easily fixed by using this polyfill suggested by MDN.

"Plunker" pen demonstrating the issue (graph does not display on IE11):
https://plnkr.co/edit/mnQV4RWKhAQOLUX225IL?p=preview

image 5

I had to use Plunker as CodePen et al is not compatible with IE11.

@wbrgss
Copy link
Contributor Author

wbrgss commented Jan 28, 2019

Related issue: #3186 (@antoinerg). Related fix: #3187.

I can fix this one myself; however, it might have to wait till next week as I'm on my own tight release schedule.

@wbrgss wbrgss added the bug something broken label Jan 28, 2019
@etpinard
Copy link
Contributor

@antoinerg wanna have a 👁️ at this bug?

@antoinerg
Copy link
Contributor

@etpinard We can either add a polyfill for prepend() or create a new function as shown in this commit
3c39b31

@etpinard
Copy link
Contributor

... or use d3:

https://stackoverflow.com/questions/26234636/d3-js-prepend-similar-to-jquery-prepend

which would be my solution of choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

No branches or pull requests

3 participants