Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cone trace doesn't show any if double-up #4072

Closed
lewisjb opened this issue Jul 23, 2019 · 7 comments · Fixed by #4306
Closed

Cone trace doesn't show any if double-up #4072

lewisjb opened this issue Jul 23, 2019 · 7 comments · Fixed by #4306
Assignees
Labels
bug something broken
Milestone

Comments

@lewisjb
Copy link

lewisjb commented Jul 23, 2019

I found that if I have two cones at the same location, then no cones show up, and no error appears.

This also happens if they are just in close proximity, like 0.01 off

Reproducible example: https://codepen.io/anon/pen/KOVwYd?editors=0010

@etpinard
Copy link
Contributor

Thanks for reporting!

That's probably our auto-size algorithm that's blowing up here.

Trace coordinates like you have in https://codepen.io/anon/pen/KOVwYd?editors=0010, would be a good candidate for an absolute sizing mode as requested in #3613

@etpinard etpinard added the bug something broken label Jul 23, 2019
@etpinard
Copy link
Contributor

Assigning @archmoj

@archmoj
Copy link
Contributor

archmoj commented Oct 24, 2019

@lewisjb would you mind testing this codepen and with other input data?
Thanks!

@archmoj
Copy link
Contributor

archmoj commented Oct 25, 2019

@etpinard FYI - here is my patch gl-vis/gl-cone3d@3c7188f,
if that looks OK I can move forward and make a PR.

@etpinard
Copy link
Contributor

Yeah, that looks ok to me. Does it cause any changes to the cone baselines?

@archmoj
Copy link
Contributor

archmoj commented Oct 25, 2019

No change. The image test passed.

@etpinard
Copy link
Contributor

Ok PR away 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants