Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spike/hover congruence #4657

Closed
nicolaskruchten opened this issue Mar 17, 2020 · 6 comments · Fixed by #4665
Closed

spike/hover congruence #4657

nicolaskruchten opened this issue Mar 17, 2020 · 6 comments · Fixed by #4665
Assignees
Milestone

Comments

@nicolaskruchten
Copy link
Contributor

It should be possible to configure things (and in unified hover mode this should be the default coerced configuration) such that whenever a hoverlabel appears, a spikeline appears and vice-versa: you should not see a spikeline without a hoverlabel.

This should hold true for mixes of bars and scatters, and work with #4656

@antoinerg
Copy link
Contributor

antoinerg commented Mar 18, 2020

@nicolaskruchten I am aware that this behavior can happen at the moment and I can reproduce it. Do you by any chance have an example where this is particularly egregious?

@antoinerg
Copy link
Contributor

Never mind: mock 24 is a good example of the problem at hand.

@antoinerg
Copy link
Contributor

@nicolaskruchten here's a simple (perhaps the simplest) solution that prevents drawing spike lines if no points are hovered on: 7c036ab .

cc @alexcjohnson

@nicolaskruchten
Copy link
Contributor Author

Hehe yes indeed. Could we make that an attribute that is coerced to true in unified hovermode? that way it can be turned off in unified mode and also optionally turned on it compare mode?

@antoinerg
Copy link
Contributor

Hehe yes indeed. Could we make that an attribute that is coerced to true in unified hovermode? that way it can be turned off in unified mode and also optionally turned on it compare mode?

Sure! Let's decide on a name for that attribute at the meeting tomorrow :)

@nicolaskruchten
Copy link
Contributor Author

Conclusion: hovered data as a possible value for the existing spikesnap attribute :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants