Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem saving png when map.style is set to 'satellite-streets' #7091

Closed
archmoj opened this issue Aug 13, 2024 · 3 comments · Fixed by #7092
Closed

Problem saving png when map.style is set to 'satellite-streets' #7091

archmoj opened this issue Aug 13, 2024 · 3 comments · Fixed by #7092

Comments

@archmoj
Copy link
Contributor

archmoj commented Aug 13, 2024

I noticed when setting map.style to 'satellite-streets' here the PNG download is not working.

@birkskyum This is blocking the RC release; wondering if you could possibly help fix it?

@archmoj archmoj changed the title Problem saving png when map.style is set to *satellite-streets* Problem saving png when map.style is set to 'satellite-streets' Aug 13, 2024
@birkskyum
Copy link
Contributor

birkskyum commented Aug 13, 2024

When i change the strings you mention and run the npm run start its alright, as shown. When do you experience the issue? When executing the render test?

@archmoj I must have misunderstood you. Exactly which png are we talking about here? how can i repro?

Screenshot 2024-08-13 at 10 09 42

@archmoj
Copy link
Contributor Author

archmoj commented Aug 13, 2024

Yes if you submit a PR with the change you made to that test by replacing the white background you will notice it.
Also if you hover over the modebar which is located on top right of the graph and click on the download PNG button you get an error in the console.

@birkskyum
Copy link
Contributor

Fantastic, so the RC is unblocked for now again 🎉 Let me know if anything else comes up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants