Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vertextcolor description to note the range of the values #3688

Merged
merged 1 commit into from
May 23, 2019

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Mar 28, 2019

Fix #3348.
@plotly/plotly_js

'Overrides *color*. While Red, green and blue colors',
'are in the range of 0 and 255; in the case of having',
'vertex color data in RGBA format, the alpha color',
'should be normalized to be between 0 and 1.'
Copy link
Contributor

@etpinard etpinard Mar 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. That sounds like an odd mesh3d behavior that doesn't have a correspondence in other traces. Can you confirm?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually there is also this bug #3741 in gl-mesh3d.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. That sounds like an odd mesh3d behavior that doesn't have a correspondence in other traces. Can you confirm?

@etpinard It is actually the case for other 3d traces e.g. scatter3d: codepen.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm starting to get a little confused by this issue.

First, see https://codepen.io/etpinard/pen/yrMmpJ?editors=0010 - looks like scatter3d is behaving inconsistently. Colors set as rgb(200,100,150,0.2) don't show an alpha channel in scatter. To show that alpha channel, one has to use the rgba prefix e.g. rgba(200,100,150,0.2). That's probably something we could add to the marker.color attribute description:

description: [
'Sets the', context, 'color.',
' It accepts either a specific color',
' or an array of numbers that are mapped to the colorscale',
' relative to the max and min values of the array or relative to',
' ' + minmaxFull + ' if set.'
].join('')

Next, if I'm understanding correctly #3348 is about vertexcolor accepting colors as [1,0,0,1] AND [255,0,0,255] see https://codepen.io/etpinard/pen/rbyXvm and https://codepen.io/etpinard/pen/GPNwYX for examples which yield the same graph using different vertexcolor denominator.


Things are a little messy here. So feel free to take this issue wherever you please.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@etpinard thanks for the review.
You are right. There is a problem with Alpha > 1 not being mapped to 0 - 1 range.
That one should actually be labelled as a bug!

@archmoj
Copy link
Contributor Author

archmoj commented May 23, 2019

This should be addressed as a bug.
Closing.

@archmoj archmoj closed this May 23, 2019
@archmoj archmoj deleted the mesh3d-vertex-color-alpha-description branch May 23, 2019 18:23
@archmoj archmoj restored the mesh3d-vertex-color-alpha-description branch May 23, 2019 19:04
@etpinard
Copy link
Contributor

@archmoj feel free to reopen this PR. 💃 - the issue I noticed in #3688 (comment) about rgb vs rgba colors can be taken care of in a separate PR.

@archmoj archmoj reopened this May 23, 2019
@archmoj archmoj merged commit 6a6ecdb into master May 23, 2019
@archmoj archmoj deleted the mesh3d-vertex-color-alpha-description branch May 23, 2019 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update vertextcolor description to note the range of the values
2 participants