Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image: improve layout defaults #4307

Merged
merged 14 commits into from
Oct 29, 2019
Merged

image: improve layout defaults #4307

merged 14 commits into from
Oct 29, 2019

Commits on Oct 25, 2019

  1. image: layout defaults: add scaleanchor, fix logic for reverse axis

    @antoinerg
    antoinerg committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    5c42db8 View commit details
    Browse the repository at this point in the history

  2. add and image mock to our mock_lists

    @antoinerg
    antoinerg committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    8184a8d View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2019

  1. image: 🔪 scaleanchor: null and improve style

    @antoinerg
    antoinerg committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    d71c3b3 View commit details
    Browse the repository at this point in the history

  2. image: test smart layout defaults via supplyAllDefaults instead of plot

    @antoinerg
    antoinerg committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    97a8d24 View commit details
    Browse the repository at this point in the history

  3. image: fix code style by breaking long line into multiple ones

    @antoinerg
    antoinerg committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    2053c58 View commit details
    Browse the repository at this point in the history

  4. image: update description to document the layout defaults

    @antoinerg
    antoinerg committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    2b0d3c3 View commit details
    Browse the repository at this point in the history

  5. image: smart default layout to constrain y axis to domain

    @antoinerg
    antoinerg committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    2306880 View commit details
    Browse the repository at this point in the history

  6. image: document smart layout default to constrain to domain

    @antoinerg
    antoinerg committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    6ad80ab View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2019

  1. image: apply layout defaults if an image is present at all

    @antoinerg
    antoinerg committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    8ef17c3 View commit details
    Browse the repository at this point in the history

  2. image: test that axis default constrain: 'domain' is applied to x axis

    @antoinerg
    antoinerg committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    d1eca2c View commit details
    Browse the repository at this point in the history

  3. fix to make sure axis layout defaults are used when no image present

    @antoinerg
    antoinerg committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    31dbc8e View commit details
    Browse the repository at this point in the history

  4. fix to set scaleanchorDflt and constrainDflt to undefined when no ima… 

    …ge is present
    @antoinerg
    antoinerg committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    29cf98f View commit details
    Browse the repository at this point in the history

  5. Merge pull request #4313 from plotly/image-constrain 

    image: constrain axes to domain, apply defaults whenever an image is present
    @antoinerg
    antoinerg authored Oct 29, 2019
    Configuration menu
    Copy the full SHA
    4233619 View commit details
    Browse the repository at this point in the history

  6. image: improve accuracy of test's description by 🔪 the word "only"

    @antoinerg
    antoinerg committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    408b46b View commit details
    Browse the repository at this point in the history