Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop contourgl and pointcloud traces from the code and API #5398

Merged
merged 3 commits into from
Jan 15, 2021
Merged

Drop contourgl and pointcloud traces from the code and API #5398

merged 3 commits into from
Jan 15, 2021

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jan 13, 2021 •
edited
Loading

Closes #4962 while addressing #5395 & #897.

The first commit 881c417
cleaned up pointcloud, contourgl, heatmapgl traces as well as gl2d subplots.

The second commit 530281a re-implemented heatmapgl while adding notes considering that heatmapgl is the only trace left using plots/gl2d and not plots/cartesian.

So I won't be surprised if one could optimize files in plots/gl2d or modules e.g. gl-plot2d v1.4.5, gl-select-box v^1.0.4 and gl-spikes2d v1.0.2.

@plotly/plotly_js

@archmoj archmoj added this to the NEXT milestone Jan 13, 2021
@nicolaskruchten
Copy link
Contributor

This PR is dropping heatmapgl, which we had discussed not doing, right?

@archmoj
Copy link
Contributor Author

archmoj commented Jan 13, 2021

This PR is dropping heatmapgl, which we had discussed not doing, right?

In the following commits, we could attempt maintaining pointcloud and heatmapgl APIs via scattergl and image and use plots/cartesian instead of plots/gl2d as we already do for scattergl. Keeping plots/gl2d just for heatmapgl which does not even support two subplots in v2 make little sense.

@nicolaskruchten
Copy link
Contributor

attempt maintaining pointcloud and heatmapgl APIs via scattergl and image

Please let us not do this. We should be dropping pointcloud and contourgl today and not reimplementing pointcloud in terms of scattergl, and not dropping heatmapgl.

We can talk about dropping heatmapgl in the meeting tomorrow if you like.

@archmoj
drop problematic gl2d plots and traces
881c417 
 - namely pointcloud, contourgl and heatmapgl
 - one could use image & scattergl instaed of heatmapgl & pointcloud
 - this very much cleans the gl2d bundle from bugs & function constructors
 - with the exception of binary-search-bounds v2 used in scattergl now
@archmoj
reimplement heatmapgl
530281a
@archmoj
improve transition test
77ab257
@archmoj archmoj changed the title Drop problematic gl2d plots and traces Drop contourgl and pointcloud traces from the code and API Jan 15, 2021
alexcjohnson
alexcjohnson approved these changes Jan 15, 2021
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! 💃

@archmoj archmoj merged commit 703d12b into master Jan 15, 2021
@archmoj archmoj deleted the gl2d-cleanup branch January 15, 2021 01:13
@archmoj archmoj mentioned this pull request Jan 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

@nicolaskruchten nicolaskruchten Awaiting requested review from nicolaskruchten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

Any support for contourgl?
3 participants
@archmoj @nicolaskruchten @alexcjohnson