Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear and restore problematic NODE environment variables before calling orca #1293

Closed
jonmmease opened this issue Dec 3, 2018 · 0 comments
Closed
Labels
bug something broken
Milestone

Comments

@jonmmease
Copy link
Contributor

plotly.py already clears the NODE_OPTIONS environment variable before calling orca because it causes and electron segfault in the version of electron that orca currently relies on (See plotly/orca#124 and #1140). In plotly/orca#149 we discovered that the ELECTRON_RUN_AS_NODE environment variable that is set by VSCode also causes a problem.

We should at least clear the ELECTRON_RUN_AS_NODE variable before calling orca, but we should also investigate whether it is possible to restore both of these environment variables immediately after the orca call.

This should be fine when we're simply calling orca --help/orca --version because the orca process exits right away. But we'll have to be careful to test orca serve call, since this launches a long running server process. We'll need to make sure that restoring these environment variables after launching the server process doesn't cause the running process any issues.

@jonmmease jonmmease added the bug something broken label Dec 3, 2018
@jonmmease jonmmease added this to the v3.5.0 milestone Dec 3, 2018
@jonmmease jonmmease changed the title clear (and restore?) problematic NODE environment variables before calling orca clear and restore problematic NODE environment variables before calling orca Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

No branches or pull requests

1 participant