Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add special validator support for layout title attributes for Plotly.js 1.43.0 #1302

Closed
jonmmease opened this issue Dec 12, 2018 · 1 comment
Milestone

Comments

@jonmmease
Copy link
Contributor

In plotly.js 1.43.0 the layout.title attribute is now a container that contains sub-attributes like text, font, xanchor, etc. The old behavior of specifying layout.title as a string and using layout.titlefont as the font container is deprecated.

Plotly.py should at least support setting layout.title as a string and setting layout.titlefont but internally map these properties to the new version.

E.g. fig.layout.title = 'A Title' is internally converted to fig.layout.title.text = 'A Title'.

Similarly, fig.layout.titlefont.family = 'Courier' is internally converted to fig.layout.title.font.family = 'Courier'.

Looks like axis titles like fig.layout.xaxis.title have also been converted into containers.

In all cases, a DeprecationWarning should be raised.

@jonmmease jonmmease added this to the v3.5.0 milestone Dec 12, 2018
@jonmmease jonmmease changed the title Add special validator support for layout title attributes Add special validator support for layout title attributes for Plotly.js 1.43.0 Dec 14, 2018
@jonmmease
Copy link
Contributor Author

Done in #1376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant