Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

template height not respected with offline.iplot? #1560

Closed
nicolaskruchten opened this issue May 10, 2019 · 1 comment · Fixed by #1579
Closed

template height not respected with offline.iplot? #1560

nicolaskruchten opened this issue May 10, 2019 · 1 comment · Fixed by #1579
Labels
bug something broken
Milestone

Comments

@nicolaskruchten
Copy link
Contributor

If I render a figure with layout.template.height=800, the final figure seems to render with a height of 525.

@jonmmease
Copy link
Contributor

Yeah, there are places in the code that add default width/height behavior if the these aren't specified.

For example:

layout_dict = fig_dict.get('layout', {})
div_width = layout_dict.get('width', default_width)
div_height = layout_dict.get('height', default_height)

But, we should track down and update all of these to also check fig.layout.template.layout.width/height.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants