-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.3.2 raises MSRV without raising minor version #398
Comments
This is also an issue for rustls: rustls/rustls#1082. |
Hi there, thanks for point this out. I've made a new release that change the edition requirement back to 2018, and yanked the broken v0.3.2. Please let me know if this fix the issue. Thanks again, |
I just restarted the build where this issue originally occurred via the GitHub UI. The result is quite inconclusive. It didn't even get to trying to built plotters and then already ran into the same problem with serde_derive-1.0.143. That's tracked in serde-rs/serde#2255. So... Sorry, I cannot really answer the question. Perhaps some of the other people that linked to this issue can do better? |
Oops, I guess there are multiple crate have ran into this problem. But still not sure - but anyway you have pointed out the problem: we cannot bump the version requirement unless we are making breaking change. I think some people may argue like 1.46 is too old to support - and AFAIK, you merely succeeded in building Rust packages with compiler older than 1.56. I think too many crate maintainers gave up supporting 1.46 currently. I kinda understand why, as this is a 2 years old release now. But still, I don't want plotters to be a breaker for downstream packages although there may be other dependencies having the same issue. But as long as the change is quite straightforward, I would like to assume this is fixed unless there's anybody complaint about this in the future. Thanks! |
As per serde-rs/serde#2255 (comment), a new |
Trying a new build of the
The This compilation error did not exist in plotters v0.3.1 |
Basically: This is #140 again.
According to git history, commit 993d9a0 raised the MSRV and was released in v0.3.2.
v0.3.1 still had
edition="2018"
according to https://github.com/plotters-rs/plotters/blob/v0.3.1/Cargo.toml#L5CC psychon/x11rb#739
The text was updated successfully, but these errors were encountered: