Release v0.3.2 raises MSRV without raising minor version

[psychon]

Basically: This is #140 again.

According to git history, commit 993d9a0 raised the MSRV and was released in v0.3.2.

v0.3.1 still had edition="2018" according to https://github.com/plotters-rs/plotters/blob/v0.3.1/Cargo.toml#L5

CC psychon/x11rb#739

[djc]

This is also an issue for rustls: rustls/rustls#1082.

[38]

Hi there, thanks for point this out. I've made a new release that change the edition requirement back to 2018, and yanked the broken v0.3.2.

Please let me know if this fix the issue.

Thanks again,
Hao

[psychon]

I just restarted the build where this issue originally occurred via the GitHub UI. The result is quite inconclusive. It didn't even get to trying to built plotters and then already ran into the same problem with serde_derive-1.0.143. That's tracked in serde-rs/serde#2255.

So... Sorry, I cannot really answer the question. Perhaps some of the other people that linked to this issue can do better?

[38]

I just restarted the build where this issue originally occurred via the GitHub UI. The result is quite inconclusive. It didn't even get to trying to built plotters and then already ran into the same problem with serde_derive-1.0.143. That's tracked in serde-rs/serde#2255.

So... Sorry, I cannot really answer the question. Perhaps some of the other people that linked to this issue can do better?

Oops, I guess there are multiple crate have ran into this problem. But still not sure - but anyway you have pointed out the problem: we cannot bump the version requirement unless we are making breaking change.

I think some people may argue like 1.46 is too old to support - and AFAIK, you merely succeeded in building Rust packages with compiler older than 1.56. I think too many crate maintainers gave up supporting 1.46 currently. I kinda understand why, as this is a 2 years old release now.

But still, I don't want plotters to be a breaker for downstream packages although there may be other dependencies having the same issue.

But as long as the change is quite straightforward, I would like to assume this is fixed unless there's anybody complaint about this in the future.

Thanks!

[psychon]

As per serde-rs/serde#2255 (comment), a new serde release happened. I restarted the failing build again. Again, it did not even try to build plotters, but instead fails for async-task-4.3.0: https://github.com/psychon/x11rb/runs/7936529563?check_suite_focus=true

[ridwanabdillahi]

@38

Trying a new build of the http crate using v0.3.3 of the plotters crate still runs into a build error. Testing with Rust 1.49.0, the MSRV for http I get the following compilation error:

error[E0658]: use of unstable library feature 'unsigned_abs'
   --> ...\registry\src\git.luolix.top-1ecc6299db9ec823\plotters-0.3.3\src\chart\builder.rs:256:51
    |
256 |         self.label_area_size[pos as usize] = size.unsigned_abs();
    |                                                   ^^^^^^^^^^^^
    |
    = note: see issue #74913 <https://github.com/rust-lang/rust/issues/74913> for more information

   Compiling tinytemplate v1.2.1
error[E0658]: use of unstable library feature 'unsigned_abs'
   --> ...\registry\src\git.luolix.top-1ecc6299db9ec823\plotters-0.3.3\src\style\font\font_desc.rs:157:15
    |
157 |         Ok((w.unsigned_abs(), h.unsigned_abs()))
    |               ^^^^^^^^^^^^
    |
    = note: see issue #74913 <https://github.com/rust-lang/rust/issues/74913> for more information

error[E0658]: use of unstable library feature 'unsigned_abs'
   --> ...\registry\src\git.luolix.top-1ecc6299db9ec823\plotters-0.3.3\src\style\font\font_desc.rs:157:33
    |
157 |         Ok((w.unsigned_abs(), h.unsigned_abs()))
    |                                 ^^^^^^^^^^^^
    |
    = note: see issue #74913 <https://github.com/rust-lang/rust/issues/74913> for more information

error: aborting due to 3 previous errors

For more information about this error, try `rustc --explain E0658`.
error: could not compile `plotters`

To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
error: build failed

The unsigned_abs feature was stabilized in Rust 1.51.0.

This compilation error did not exist in plotters v0.3.1