-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] currently nightly compiler cannot build plotters due to bug in pathfinder (simd) #554
Comments
Any news on this? It appears the bugfix is pushed into upstream on the pathfinder repo. |
I believe that there is no new verison published on crates.io yet. You can open an issue at their repo or wait until a new version is published. If you can, simply omit the |
fyi you can also temporarily add a patch in case you're producing a binary: # Cargo.toml
[patch.crates-io]
pathfinder_simd = { git = "https://github.com/servo/pathfinder.git", rev = "dc6034f" }
pathfinder_geometry = { git = "https://github.com/servo/pathfinder.git", rev = "dc6034f" } edit: you may also need to delete or update the |
That works, thank you! |
A new version of pathfinder_simd has been published. This should hopefully be fixed now. |
Yup, it is fixed. |
here's what i'm getting in attempting to build plotters 0.3.5 today on nightly pathfinder_simd = { version = "0.5", optional = true }
plotters = { version = "0.3", optional = true } error[E0557]: feature has been removed
--> /home/bion/.cargo/registry/src/index.crates.io-6f17d22bba15001f/pathfinder_simd-0.5.2/src/lib.rs:11:61
|
11 | #![cfg_attr(pf_rustc_nightly, feature(link_llvm_intrinsics, platform_intrinsics))]
| ^^^^^^^^^^^^^^^^^^^ feature has been removed
|
= note: SIMD intrinsics use the regular intrinsics ABI now
error[E0635]: unknown feature `stdsimd`
--> /home/bion/.cargo/registry/src/index.crates.io-6f17d22bba15001f/pathfinder_simd-0.5.2/src/lib.rs:12:49
|
12 | #![cfg_attr(pf_rustc_nightly, feature(simd_ffi, stdsimd))]
| ^^^^^^^ this works:
and this works, so the issue is not with the minor version numbers, it's with "optional"
|
@bionicles what happens if you do |
seems fixed, i can't repro the issue anymore, now plotters is working off of 0.5.3 even if I cargo clean, with minor versions present or absent, could be related to nightly 1.80 or just my cargo having some memory to use 0.5.3 now, plotters can get the pathfinder_simd on nightly so this issue could be closed I reckon |
It was probably stuck on |
I am closing this issue. |
There is a bug in the most recent pathfinder version which currently prohibits building this package for with the newest nightly compiler. This means docs.rs will fail to build if a new version is to be published. There are multiple ways to deal with this bug:
ttf
feature (which enables the dependency). Check also docs - annotate objects who depend on features #553 which enables all features for docs.rs specifically!My hope is that the bugfix is pushed upstream soon and a new version of pathfinder is released.
Error message
The text was updated successfully, but these errors were encountered: