Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please support Windows #80

Open
jnunderwood opened this issue Jul 24, 2023 · 1 comment
Open

Please support Windows #80

jnunderwood opened this issue Jul 24, 2023 · 1 comment
Labels
🌟 goal: addition Addition of new feature 🖥️ os: windows Specific to Microsoft Windows 🟩 priority: low Low priority and doesn't need to be rushed

Comments

@jnunderwood
Copy link

Problem

The new rust version of pls does not support Windows.

Description

I love pls! The old python version of pls supported Windows (mostly) and is my default ls program. However, the new rust version does not. It is also really useful for those of us who use both Windows and Linux (WSL) to have the same ls tool on both platforms. Please consider supporting Windows with the new rust implementation. Thank you!

@dhruvkb
Copy link
Collaborator

dhruvkb commented Jul 24, 2023

@jnunderwood with Python it was easier to build for Windows because the source code was mostly unchanged except for some sys.platform checks. With Rust it is a bit difficult because Rust programs must be compiled individually for each of the systems.

I'm not opposed to the idea, it's only that I don't have much experience with Rust and I anticipate the finished product might not be up to the mark. I am happy to review and merge any PRs that add or improve Windows compatibility. Alternatively, if this ticket gets enough upvotes, I'll put in the time and implement it myself.

@dhruvkb dhruvkb added 🟩 priority: low Low priority and doesn't need to be rushed 🌟 goal: addition Addition of new feature 🖥️ os: windows Specific to Microsoft Windows labels Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 goal: addition Addition of new feature 🖥️ os: windows Specific to Microsoft Windows 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Development

No branches or pull requests

2 participants