Undo/Redo weirdness

[tmhglnd]

I'm encountering some strange behaviour when undo-ing / redo-ing during patching.

For example:

1. Sometimes not all objects are moved back when multiple are selected, I move them, but then decide to undo the move. Some objects stick around. Below is illustrated what happens to me when using undo after a drag of multiple objects. At some point plugData really has no idea anymore where objects came from. Also if I decide to move a single object all of a sudden but undo that.

2. When creating an object, then hitting enter, then starting a new-object, but instead of continuing I decide now, i hit undo, but then the previous object is deleted, instead of removing the empty object, which I would expect.

[timothyschoen]

Oh, I was aware there were still some undo issues, thanks for giving some examples. I'll fix these!

[tmhglnd]

Thanks for giving it a look! Just wanted to add one more little thing:

3. In bigger patches, after moving one thing and undo-ing, everything just moves a little bit, like only a few pixels.

[timothyschoen]

68b1957 should fix issues 1 and 2!

[jamshark70]

OK to add another issue here?

1. Mouse select an object or two.
2. Arrow-key move them on the canvas.
3. Undo -- nothing happens.

[tmhglnd]

I can replicate this issue. But, when I move the objects 2x or more I can undo once. Although clearly some undo history gets messed up in the process. Because if I follow these steps this is what happens:

1. Add 2 objects
2. Select them and move them with arrow keys 2x times
3. Undo 1x (they move back one step)
4. Undo 1x (last object added is deleted..., this should be moving back one more time)

[timothyschoen]

OK to add another issue here?

1. Mouse select an object or two.

2. Arrow-key move them on the canvas.

3. Undo -- nothing happens.

I can only reproduce this on v0.9.1, but not anymore on the nightly builds for v0.9.2. So maybe this is already fixed?

[timothyschoen]

Thanks for giving it a look! Just wanted to add one more little thing:

3. In bigger patches, after moving one thing and undo-ing, everything just moves a little bit, like only a few pixels.

This also appears to be fixed on nightly builds. On v0.9.1, it still happened for me with metro-help.pd, but in v0.9.2 (nightly) it no longer does.

[tmhglnd]

You're right, number 3 is fixed for me in 0.9.2! Great!

Number 2 is fixed as well! Although for me it requires 2x undo to get rid of the box. But nevertheless better than how it worked before, thanks.

Number 1 is as good as fixed, although I still see a small movement in the object when cmd-z is used. But it is tiny... It is no big deal but just for completion wanted to mention it, haha.

[timothyschoen]

You're right, number 3 is fixed for me in 0.9.2! Great!

Number 2 is fixed as well! Although for me it requires 2x undo to get rid of the box. But nevertheless better than how it worked before, thanks.

Number 1 is as good as fixed, although I still see a small movement in the object when cmd-z is used. But it is tiny... It is no big deal but just for completion wanted to mention it, haha.

Seems to be an issue specific to sliders, I don't get it with toggles. Pretty strange, I'll take a look at it later

[tmhglnd]

Not sure if this is related to the undo/redo history, but maybe it is:

4. When option-dragging an object (or group) to copy it, then do something else (like connecting something to this object, or copying some other objects, or creating an object), the object(s) jump back to it's "origin" (near the original object of where it was copied from). It seems the location after the copy-drag is not saved. Using the 0.9.2 nightly build.

[timothyschoen]

Not sure if this is related to the undo/redo history, but maybe it is:

4. When `option-dragging` an object (or group) to copy it, then do something else (like connecting something to this object, or copying some other objects, or creating an object), the object(s) jump back to it's "origin" (near the original object of where it was copied from). It seems the location after the copy-drag is not saved. Using the `0.9.2` nightly build.

Oh, yep I messed this up when fixing the undo bug! Should be fixed with aa7a82a