Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix open/click messages to various ELSE objects #635

Closed
porres opened this issue Mar 3, 2023 · 7 comments
Closed

Fix open/click messages to various ELSE objects #635

porres opened this issue Mar 3, 2023 · 7 comments

Comments

@porres
Copy link
Collaborator

porres commented Mar 3, 2023

this is unrelated to else/click -> #634 because I mean objects that are not using this object but calling an internal click function on the code, like [initmess] (that I mentioned in another issue, see --> #633 ) and now I tested [sfont~] and [loadbanger]. I now think no objects in ELSE have the click function enabled.

@timothyschoen
Copy link
Collaborator

Fixed!

@porres
Copy link
Collaborator Author

porres commented Mar 5, 2023

I can confirm with the current nightly build that else/click works and so does [imitmess], but I tried clicling in [sfont~] and [loadbanger] and it didn't work, so I'd ask you to check if all are really working.

maybe reopen this?

@porres
Copy link
Collaborator Author

porres commented Mar 5, 2023

Click should also be enabled in else's loadbanger and cyclone's loadmess. The other cases require other functionalities enabled that don't seem to be working either.

ELSE:

  • lb/loadbanger
  • colors (but 'pick' message is not working either
  • midi (open message not working either)
  • openfile (seems not ported/supported yet)
  • rec (open message not working either)
  • sfont~ (open message not working either)

cyclone:

  • loadmess
  • capture (open message not working either)
  • coll (open message not working either)
  • prob (no open message to not work either)
  • seq (read message not working either)
  • table (open message not working either)

read/open message either open a text window or call a dialog to choose a file

@porres
Copy link
Collaborator Author

porres commented Mar 5, 2023

again, tested with latest nightly build

@timothyschoen timothyschoen reopened this Mar 5, 2023
@timothyschoen timothyschoen changed the title click function in ELSE objects not working either Fix open/click messages to various ELSE objects Mar 5, 2023
@timothyschoen
Copy link
Collaborator

Thanks for finding these!

@timothyschoen timothyschoen moved this to Todo in v0.8.0 May 22, 2023
@timothyschoen
Copy link
Collaborator

These all work now, except for [coll], for which I'll open a new issue.

@github-project-automation github-project-automation bot moved this from Todo to Done in v0.8.0 Aug 17, 2023
@porres
Copy link
Collaborator Author

porres commented Aug 18, 2023

yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants