Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDB functions not accepting negative residue numbers #1089

Open
carlocamilloni opened this issue Jun 26, 2024 · 1 comment
Open

PDB functions not accepting negative residue numbers #1089

carlocamilloni opened this issue Jun 26, 2024 · 1 comment

Comments

@carlocamilloni
Copy link
Member

@gtribello @GiovanniBussi @maxbonomi @Iximiel we were doing some test using SAXS on PDB constructs and we found out that PLUMED PDB functions do not accept negative residue numbers becasue they all take unsigned in input.
For example getResidueRange(unsigned start, unsigned end) ecc.
I cannot remember if there was any reason for this. If not we would see if it is possible to modify this behavior.
Do you expect this to break somethign else?

@GiovanniBussi
Copy link
Member

For atom numbers I think we have to stick to positive (>=1).

For residue numbers I don't know any reason to limit to positive. However, we should check carefully all places where residues are entered. A possible tricky thing is what happens if we allow users to use ranges (1-10 is clear, what about -10--1? Maybe it works, but I am afraid it could not).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants