You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@gtribello@GiovanniBussi@maxbonomi@Iximiel we were doing some test using SAXS on PDB constructs and we found out that PLUMED PDB functions do not accept negative residue numbers becasue they all take unsigned in input.
For example getResidueRange(unsigned start, unsigned end) ecc.
I cannot remember if there was any reason for this. If not we would see if it is possible to modify this behavior.
Do you expect this to break somethign else?
The text was updated successfully, but these errors were encountered:
For atom numbers I think we have to stick to positive (>=1).
For residue numbers I don't know any reason to limit to positive. However, we should check carefully all places where residues are entered. A possible tricky thing is what happens if we allow users to use ranges (1-10 is clear, what about -10--1? Maybe it works, but I am afraid it could not).
@gtribello @GiovanniBussi @maxbonomi @Iximiel we were doing some test using SAXS on PDB constructs and we found out that PLUMED PDB functions do not accept negative residue numbers becasue they all take
unsigned
in input.For example getResidueRange(unsigned start, unsigned end) ecc.
I cannot remember if there was any reason for this. If not we would see if it is possible to modify this behavior.
Do you expect this to break somethign else?
The text was updated successfully, but these errors were encountered: