From cf5981a38fa5ee7ec7ef0abe82abd36785d7fc43 Mon Sep 17 00:00:00 2001 From: Michael Plump Date: Wed, 30 Sep 2020 14:50:44 -0400 Subject: [PATCH] Remove Java 8 from the CI systems. Halyard compiles to Java 11 as of #1802. --- .github/workflows/build.yml | 7 +------ .github/workflows/pr.yml | 7 +------ .github/workflows/release.yml | 7 +------ Dockerfile.compile | 5 +---- 4 files changed, 4 insertions(+), 22 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 46f9ed3f0e..c37af48626 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -16,11 +16,6 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - # Install Java 8 for cross-compilation support. Setting it up before - # Java 11 means it comes later in $PATH (because of how setup-java works) - - uses: actions/setup-java@v1 - with: - java-version: 8 - uses: actions/setup-java@v1 with: java-version: 11 @@ -31,4 +26,4 @@ jobs: restore-keys: | ${{ runner.os }}-gradle- - name: Build - run: ./gradlew -PenableCrossCompilerPlugin=true build --stacktrace + run: ./gradlew build --stacktrace diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index d13d376afd..1240044292 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -10,11 +10,6 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - # Install Java 8 for cross-compilation support. Setting it up before - # Java 11 means it comes later in $PATH (because of how setup-java works) - - uses: actions/setup-java@v1 - with: - java-version: 8 - uses: actions/setup-java@v1 with: java-version: 11 @@ -25,4 +20,4 @@ jobs: restore-keys: | ${{ runner.os }}-gradle- - name: Build - run: ./gradlew -PenableCrossCompilerPlugin=true build + run: ./gradlew build diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 2c98234641..a75638a953 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -15,11 +15,6 @@ jobs: steps: - uses: actions/checkout@v2 - run: git fetch --prune --unshallow - # Install Java 8 for cross-compilation support. Setting it up before - # Java 11 means it comes later in $PATH (because of how setup-java works) - - uses: actions/setup-java@v1 - with: - java-version: 8 - uses: actions/setup-java@v1 with: java-version: 11 @@ -45,7 +40,7 @@ jobs: BINTRAY_API_KEY: ${{ secrets.BINTRAY_API_KEY }} RELEASE_VERSION: ${{ steps.release_info.outputs.RELEASE_VERSION }} run: | - ./gradlew -PenableCrossCompilerPlugin=true --info -Pversion="${RELEASE_VERSION}" -PbintrayUser="${BINTRAY_USER}" -PbintrayKey="${BINTRAY_API_KEY}" publish + ./gradlew --info -Pversion="${RELEASE_VERSION}" -PbintrayUser="${BINTRAY_USER}" -PbintrayKey="${BINTRAY_API_KEY}" publish - name: Create release if: steps.release_info.outputs.SKIP_RELEASE == 'false' uses: actions/create-release@v1 diff --git a/Dockerfile.compile b/Dockerfile.compile index 911bc0d8bb..202cbe6cb9 100644 --- a/Dockerfile.compile +++ b/Dockerfile.compile @@ -1,15 +1,12 @@ FROM ubuntu:bionic RUN apt-get update && apt-get install -y \ - openjdk-8-jdk \ openjdk-11-jdk \ && rm -rf /var/lib/apt/lists/* LABEL maintainer="sig-platform@spinnaker.io" -ENV JAVA_HOME /usr/lib/jvm/java-11-openjdk-amd64 -ENV JDK_18 /usr/lib/jvm/java-8-openjdk-amd64 ENV GRADLE_USER_HOME /workspace/.gradle ENV GRADLE_OPTS -Xmx4g ARG VERSION # You can't use an ARG in a CMD (because it isn't available anymore when you run # the container) so we have to store it in an ENV. ENV VERSIONARG="-Pversion=$VERSION" -CMD ./gradlew --no-daemon $VERSIONARG -PenableCrossCompilerPlugin=true halyard-web:installDist -x test +CMD ./gradlew --no-daemon $VERSIONARG halyard-web:installDist -x test