Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update airbyte and use upstream chart #443

Merged
merged 20 commits into from
Jan 16, 2023
Merged

Conversation

davidspek
Copy link
Contributor

@davidspek davidspek commented Nov 16, 2022

Summary

This PR migrates our Airbyte setup to use the upstream helm chart, along with a change to allow for adding labels to pods. Once airbytehq/airbyte#19474 is merged we should be able to use the upstream airbyte helm chart directly.

A lot has changed in the chart structure, and with it the way Airbyte is configured. Using the upstream chart will hopefully make is so that we don't run into errors due to misconfiguration of Airbyte because our forked chart isn't up to date.

Test Plan

Local linking.

Checklist

  • No images hosted from dockerhub
  • Are dashboards present to understand the health of the application. There must be at least 1 of these
    • all databases should have dashboards
    • ideally also have at least cpu/mem utilization dashboards for webserver tier of the app
    • you can use plural from-grafana to convert a grafana dashboard found via google to our CRD
  • Are scaling runbooks present
    • all databases must have scaling runbooks
    • you can use the charts in pluralsh/module-library to accelerate this
  • do you need to add config overlays?
    • inputing secrets
    • configuring autoscaling
  • If there’s a web-facing component to the app, we need to support OIDC authentication and setting up private networks if no authentication option is viable
  • All major clouds must be supported
    • Azure
    • AWS
    • GCP

@davidspek davidspek changed the title WIP: Sync our Airbyte helm chart fork feat: update airbyte and use upstream chart Dec 21, 2022
@davidspek davidspek marked this pull request as ready for review December 21, 2022 15:26
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
@davidspek
Copy link
Contributor Author

This is blocked by us needing to push out a dummy airbyte update once the new console is released so we can migrate values.yaml into default-values.yaml before this upgrade is done.

Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
@davidspek davidspek marked this pull request as draft January 11, 2023 14:00
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
@davidspek davidspek marked this pull request as ready for review January 16, 2023 10:24
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
@davidspek davidspek merged commit 4dfb96f into main Jan 16, 2023
@davidspek davidspek deleted the remove-airbyte-fork branch January 16, 2023 11:04
@plural-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@davidspek davidspek restored the remove-airbyte-fork branch December 19, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants