Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: sftpgo workload identity + fix sftpgo ui + add loadbalancer for TCP services #572

Merged
merged 9 commits into from
Mar 24, 2023
Merged

feat: sftpgo workload identity + fix sftpgo ui + add loadbalancer for TCP services #572

merged 9 commits into from
Mar 24, 2023

Conversation

walkoss
Copy link
Contributor

@walkoss walkoss commented Mar 14, 2023

Summary

  • Add sftpgo workload identity
  • Fix sftp ui ingress path
  • Add optional Service (LoadBalancer) to access TCP services through a domain name

Checklist

  • No images hosted from dockerhub
  • Are dashboards present to understand the health of the application. There must be at least 1 of these
    • all databases should have dashboards
    • ideally also have at least cpu/mem utilization dashboards for webserver tier of the app
    • you can use plural from-grafana to convert a grafana dashboard found via google to our CRD
  • Are scaling runbooks present
    • all databases must have scaling runbooks
    • you can use the charts in pluralsh/module-library to accelerate this
  • do you need to add config overlays?
    • inputing secrets
    • configuring autoscaling
  • If there’s a web-facing component to the app, we need to support OIDC authentication and setting up private networks if no authentication option is viable
  • All major clouds must be supported
    • Azure
    • AWS
    • GCP

@walkoss walkoss changed the title Feat/sftpgo wi feat: sftpgo workload identity + fix sftpgo ui + add loadbalancer for TCP services Mar 14, 2023
@walkoss walkoss marked this pull request as draft March 14, 2023 23:53
@walkoss
Copy link
Contributor Author

walkoss commented Mar 14, 2023 •
edited
Loading

Do I need to upgrade chart version?

@walkoss walkoss marked this pull request as ready for review March 15, 2023 11:17
michaeljguarino
michaeljguarino reviewed Mar 16, 2023
View reviewed changes
sftpgo/terraform/gcp/variables.tf
variable "roles" {
type = list(string)
description = "A list of roles to be added to the sftpgo workload identity service account"
default = []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should you add a default here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No default value is required initially. Only needed for the GCS output destination.
Should it be added even if it is not used or let users assign it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, np

@walkoss walkoss requested review from michaeljguarino and removed request for davidspek March 20, 2023 14:54
michaeljguarino
michaeljguarino approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@michaeljguarino michaeljguarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably good to go, just handle the merge conflicts

@walkoss
Copy link
Contributor Author

walkoss commented Mar 23, 2023 •
edited
Loading

@michaeljguarino all good, can be merged, should we upgrade chart version?

@michaeljguarino
Copy link
Member

@walkoss yes definitely upgrade the chart vsn if there are any changes (otherwise it won't be pushed)

@michaeljguarino michaeljguarino merged commit 7dd169a into pluralsh:main Mar 24, 2023
@walkoss walkoss deleted the feat/sftpgo-wi branch March 24, 2023 16:08
@plural-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljguarino michaeljguarino michaeljguarino approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@walkoss @michaeljguarino @plural-bot