Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bootstrap-gcp): add variable to allow gke to pull image from container registry #598

Merged
merged 2 commits into from
Mar 27, 2023

Conversation

walkoss
Copy link
Contributor

@walkoss walkoss commented Mar 27, 2023

Summary

  • Added variable to grant generated node service accounts role to pull images from Google Container Registry, default to false

Test Plan

  • Set the variable to true and was able to pull image from a private container registry on the same project

Checklist

  • No images hosted from dockerhub
  • Are dashboards present to understand the health of the application. There must be at least 1 of these
    • all databases should have dashboards
    • ideally also have at least cpu/mem utilization dashboards for webserver tier of the app
    • you can use plural from-grafana to convert a grafana dashboard found via google to our CRD
  • Are scaling runbooks present
    • all databases must have scaling runbooks
    • you can use the charts in pluralsh/module-library to accelerate this
  • do you need to add config overlays?
    • inputing secrets
    • configuring autoscaling
  • If there’s a web-facing component to the app, we need to support OIDC authentication and setting up private networks if no authentication option is viable
  • All major clouds must be supported
    • Azure
    • AWS
    • GCP

Copy link
Member

@michaeljguarino michaeljguarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could see an argument this should be defaulted to true actually. You also need to bump the deps.yaml vsn though

@walkoss
Copy link
Contributor Author

walkoss commented Mar 27, 2023

I could see an argument this should be defaulted to true actually. You also need to bump the deps.yaml vsn though

@michaeljguarino this is false by default https://registry.terraform.io/modules/terraform-google-modules/kubernetes-engine/google/latest?tab=inputs

@michaeljguarino michaeljguarino merged commit a7c98dd into pluralsh:main Mar 27, 2023
@walkoss walkoss deleted the feat/bootstrap-gcp branch March 27, 2023 17:03
@plural-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants