Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: started onboard weaviate #633

Merged
merged 1 commit into from
Apr 8, 2023

Conversation

walkoss
Copy link
Contributor

@walkoss walkoss commented Apr 8, 2023

Summary

Test Plan

Checklist

  • No images hosted from dockerhub
  • Are dashboards present to understand the health of the application. There must be at least 1 of these
    • all databases should have dashboards
    • ideally also have at least cpu/mem utilization dashboards for webserver tier of the app
    • you can use plural from-grafana to convert a grafana dashboard found via google to our CRD
  • Are scaling runbooks present
    • all databases must have scaling runbooks
    • you can use the charts in pluralsh/module-library to accelerate this
  • do you need to add config overlays?
    • inputing secrets
    • configuring autoscaling
  • If there’s a web-facing component to the app, we need to support OIDC authentication and setting up private networks if no authentication option is viable
  • All major clouds must be supported
    • Azure
    • AWS
    • GCP

Copy link
Member

@michaeljguarino michaeljguarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we still need to merge #631 to get the contributor tags to reflect, but once that's in we can get this available

Comment on lines +28 to +30
registry: dkr.plural.sh
tag: 1.18.0
repo: weaviate/semitechnologies/weaviate
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaeljguarino can you confirm that all images in vendor_images.yaml will be sync within dkr.plural.sh registry with application name as prefix?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's correct

@walkoss
Copy link
Contributor Author

walkoss commented Apr 8, 2023

we still need to merge #631 to get the contributor tags to reflect, but once that's in we can get this available

@michaeljguarino I can remove those for now in order to continue this new application integration with features like backup in bucket, authenticiation with OIDC and so on, wdyt?

@michaeljguarino
Copy link
Member

we still need to merge #631 to get the contributor tags to reflect, but once that's in we can get this available

@michaeljguarino I can remove those for now in order to continue this new application integration with features like backup in bucket, authenticiation with OIDC and so on, wdyt?

Do you want to do that this weekend? I can theoretically unblock if you want to work on it quickly otherwise could pick it up on Monday as well

@walkoss
Copy link
Contributor Author

walkoss commented Apr 8, 2023

we still need to merge #631 to get the contributor tags to reflect, but once that's in we can get this available

@michaeljguarino I can remove those for now in order to continue this new application integration with features like backup in bucket, authenticiation with OIDC and so on, wdyt?

Do you want to do that this weekend? I can theoretically unblock if you want to work on it quickly otherwise could pick it up on Monday as well

Yes, I would like to work on it today. As it is private, will I be able to bundle install it with the CLI? If not, that's not a problem, I will helm install and terraform apply manually.
Otherwise I can publish this app on my own plural account and then remove it later to integrate it here? I didn't try publishing on my own account but could be interesting to see. Could I install it with the plural cli (to check the configuration, etc)?

@michaeljguarino
Copy link
Member

You can technically publish it via your own account but we'd have to manually reparent it under the standard plural publisher if we were to bring it back in this repository fully, which is ok. Let me try to get you unblocked though

@michaeljguarino michaeljguarino merged commit 9d7fa34 into pluralsh:main Apr 8, 2023
@walkoss
Copy link
Contributor Author

walkoss commented Apr 8, 2023

You can technically publish it via your own acco

Thank you

@walkoss walkoss deleted the feat/weaviate branch April 8, 2023 17:12
@plural-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@plural-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants