Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Jupyterhub OIDC + Cleanup #635

Merged
merged 2 commits into from
Apr 10, 2023
Merged

feat: Jupyterhub OIDC + Cleanup #635

merged 2 commits into from
Apr 10, 2023

Conversation

michaeljguarino
Copy link
Member

Summary

This PR handles a number of fixups for jupyterhub

  • Move to jupyterhub's chart from bitnami's, which is quite limited in capability
  • properly configure OIDC
  • use postgres as backing datastore

Test Plan

local link (I also pushed these artifacts locally to help fix everything)

Checklist

  • No images hosted from dockerhub
  • Are dashboards present to understand the health of the application. There must be at least 1 of these
    • all databases should have dashboards
    • ideally also have at least cpu/mem utilization dashboards for webserver tier of the app
    • you can use plural from-grafana to convert a grafana dashboard found via google to our CRD
  • Are scaling runbooks present
    • all databases must have scaling runbooks
    • you can use the charts in pluralsh/module-library to accelerate this
  • do you need to add config overlays?
    • inputing secrets
    • configuring autoscaling
  • If there’s a web-facing component to the app, we need to support OIDC authentication and setting up private networks if no authentication option is viable
  • All major clouds must be supported
    • Azure
    • AWS
    • GCP

@michaeljguarino
Jupyterhub OIDC + Cleanup
6412c17 
This PR handles a number of fixups for jupyterhub

* Move to jupyterhub's chart from bitnami's, which is quite limited in capability
* properly configure OIDC
* use postgres as backing datastore
@michaeljguarino michaeljguarino added the enhancement New feature or request label Apr 10, 2023
@michaeljguarino michaeljguarino requested a review from a team April 10, 2023 19:59
@michaeljguarino michaeljguarino changed the title Jupyterhub OIDC + Cleanup feat: Jupyterhub OIDC + Cleanup Apr 10, 2023
@michaeljguarino michaeljguarino merged commit 7c9412e into main Apr 10, 2023
@michaeljguarino michaeljguarino deleted the jupyterhub-cleanup branch April 10, 2023 20:06
@plural-bot
Copy link
Contributor

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidspek davidspek Awaiting requested review from davidspek

Assignees
No one assigned
Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaeljguarino @plural-bot