Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onboard directus #639

Merged
merged 4 commits into from
Apr 13, 2023
Merged

Conversation

walkoss
Copy link
Contributor

@walkoss walkoss commented Apr 13, 2023

Summary

Test Plan

  • Deployed helm chart + terraform locally

Next

  • Set docker image from plural registry
  • Configure file storage backend (s3, gcs, blob)
  • Configure OIDC

Checklist

  • No images hosted from dockerhub
  • Are dashboards present to understand the health of the application. There must be at least 1 of these
    • all databases should have dashboards
    • ideally also have at least cpu/mem utilization dashboards for webserver tier of the app
    • you can use plural from-grafana to convert a grafana dashboard found via google to our CRD
  • Are scaling runbooks present
    • all databases must have scaling runbooks
    • you can use the charts in pluralsh/module-library to accelerate this
  • do you need to add config overlays?
    • inputing secrets
    • configuring autoscaling
  • If there’s a web-facing component to the app, we need to support OIDC authentication and setting up private networks if no authentication option is viable
  • All major clouds must be supported
    • Azure
    • AWS
    • GCP

@@ -0,0 +1,22 @@
1. Get the application URL by running these commands:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rm this file

@@ -0,0 +1,10 @@
resource "kubernetes_namespace" "directus" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does directus not require S3 or another form of object storage?

Copy link
Contributor Author

@walkoss walkoss Apr 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They don't need it to get it work, but I'm planning to add a file storage to the bucket later along with postgres backend and oidc auth

@michaeljguarino
Copy link
Member

We should definitely use the postgres operator to set up a proper db here as well, you should be able to see a lot of prior art using the module-library postgres chart that wraps a lot of the helpful resources together for it

@walkoss
Copy link
Contributor Author

walkoss commented Apr 13, 2023

We should definitely use the postgres operator to set up a proper db here as well, you should be able to see a lot of prior art using the module-library postgres chart that wraps a lot of the helpful resources together for it

Yes for sure! Might need some help for this maybe

@michaeljguarino
Copy link
Member

you can see some postgres related templating here: https://github.com/pluralsh/plural-artifacts/pull/635/files

jupyterhub was weird because we had to feed it the entire postgres url, which isn't needed for directus, looks like you can just wire up these env vars: https://docs.directus.io/self-hosted/config-options.html to give it the right db configuration. You'll almost certainly need to add DB_SSL__REJECT_UNAUTHORIZED=false too as an env var

it looks like directus does require s3/gcs/etc so might want to revert the kube terraform module and go back to the standard cloud specific ones too

@michaeljguarino michaeljguarino merged commit 1f97d6c into pluralsh:main Apr 13, 2023
@walkoss walkoss deleted the feat/directus branch April 13, 2023 20:19
@plural-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants