Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support mimir basic auth #668

Merged
merged 4 commits into from
Apr 21, 2023
Merged

feat: Support mimir basic auth #668

merged 4 commits into from
Apr 21, 2023

Conversation

michaeljguarino
Copy link
Member

@michaeljguarino michaeljguarino commented Apr 20, 2023 •
edited
Loading

Summary

Use same basic auth templating as done for loki w/ mimir

Test Plan

local link

Checklist

  • No images hosted from dockerhub
  • Are dashboards present to understand the health of the application. There must be at least 1 of these
    • all databases should have dashboards
    • ideally also have at least cpu/mem utilization dashboards for webserver tier of the app
    • you can use plural from-grafana to convert a grafana dashboard found via google to our CRD
  • Are scaling runbooks present
    • all databases must have scaling runbooks
    • you can use the charts in pluralsh/module-library to accelerate this
  • do you need to add config overlays?
    • inputing secrets
    • configuring autoscaling
  • If there’s a web-facing component to the app, we need to support OIDC authentication and setting up private networks if no authentication option is viable
  • All major clouds must be supported
    • Azure
    • AWS
    • GCP

@michaeljguarino
Support mimir basic auth
f0609fb 
Use same basic auth templating as done for loki w/ mimir
@michaeljguarino michaeljguarino added the enhancement New feature or request label Apr 20, 2023
@michaeljguarino michaeljguarino requested a review from a team April 20, 2023 17:59
@michaeljguarino michaeljguarino changed the title Support mimir basic auth feat: Support mimir basic auth Apr 20, 2023
@michaeljguarino michaeljguarino merged commit 0a4a35a into main Apr 21, 2023
@michaeljguarino michaeljguarino deleted the mimir-basic-auth branch April 21, 2023 16:23
@plural-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@plural-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidspek davidspek Awaiting requested review from davidspek

Assignees
No one assigned
Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaeljguarino @plural-bot