Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Stats and StatsGl don't remove previous class names on rerender #1994

Merged
merged 2 commits into from
Jun 15, 2024
Merged

fix: Stats and StatsGl don't remove previous class names on rerender #1994

merged 2 commits into from
Jun 15, 2024

Conversation

lukehorvat
Copy link
Contributor

Why

Both Stats and StatsGl don't remove class names set via the className prop on rerender. In the following example, if showStats is initially false and then later changes to true, the Hidden class does not get removed from the DOM element.

<Stats className={`Stats ${showStats ? '' : 'Hidden'}`} />

What

Fixed by removing the previously added class names during useEffect cleanup.

Checklist

  • Ready to be merged

@vercel Vercel
Copy link

vercel bot commented Jun 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drei ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2024 9:35pm

@codesandbox-ci CodeSandbox CI
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@CodyJasonBennett CodyJasonBennett merged commit 18c24eb into pmndrs:master Jun 15, 2024
4 checks passed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 9.107.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lukehorvat lukehorvat deleted the StatsGl-classNames-cleanup branch June 16, 2024 17:26
@David-Besse David-Besse mentioned this pull request Jul 7, 2024
Merged
@X-oss-byte X-oss-byte mentioned this pull request Jul 7, 2024
Open
@NOUIY NOUIY mentioned this pull request Jul 8, 2024
Open
@carltrepanier carltrepanier mentioned this pull request Jul 8, 2024
Merged
@Ysrbolles Ysrbolles mentioned this pull request Jul 9, 2024
Merged
@hartmutobendorf hartmutobendorf mentioned this pull request Jul 17, 2024
Open
@carltrepanier carltrepanier mentioned this pull request Jul 17, 2024
Merged
@NOUIY NOUIY mentioned this pull request Jul 17, 2024
Open
@Ysrbolles Ysrbolles mentioned this pull request Jul 17, 2024
Merged
@X-oss-byte X-oss-byte mentioned this pull request Jul 17, 2024
Open
@NOUIY NOUIY mentioned this pull request Jul 18, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Jul 18, 2024
Open
@NOUIY NOUIY mentioned this pull request Jul 20, 2024
Open
This was referenced Jul 20, 2024
Open
Open
@NOUIY NOUIY mentioned this pull request Jul 21, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Jul 28, 2024
Open
@NOUIY NOUIY mentioned this pull request Jul 30, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Aug 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukehorvat @CodyJasonBennett