Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(utils): subscribe method of createJSONStorage should only run in the client #2585

Merged
merged 12 commits into from
Jun 3, 2024
Merged

fix(utils): subscribe method of createJSONStorage should only run in the client #2585

merged 12 commits into from
Jun 3, 2024

Commits on May 29, 2024

  1. fix: prevent calling storage subscribe unless in client

    @mhsattarian
    mhsattarian committed May 29, 2024
    Configuration menu
    Copy the full SHA
    a1b1998 View commit details
    Browse the repository at this point in the history

  2. test: add test for getStringStorage method from createJSONStorage to … 

    …not be called in server
    @mhsattarian
    mhsattarian committed May 29, 2024
    Configuration menu
    Copy the full SHA
    71d2fa0 View commit details
    Browse the repository at this point in the history

  3. use try-catch

    @dai-shi
    dai-shi committed May 29, 2024
    Configuration menu
    Copy the full SHA
    6ca781f View commit details
    Browse the repository at this point in the history

  4. Revert "test: add test for getStringStorage method from createJSONSto… 

    …rage to not be called in server"

This reverts commit 71d2fa0.
    @mhsattarian
    mhsattarian committed May 29, 2024
    Configuration menu
    Copy the full SHA
    2838849 View commit details
    Browse the repository at this point in the history

  5. test: checking localStorage/sessionStorage access with createJSONStor… 

    …age in server
    @mhsattarian
    mhsattarian committed May 29, 2024
    Configuration menu
    Copy the full SHA
    f38edf1 View commit details
    Browse the repository at this point in the history

  6. test: improve checking localStorage/sessionStorage access with create… 

    …JSONStorage in server
    @mhsattarian
    mhsattarian committed May 29, 2024
    Configuration menu
    Copy the full SHA
    4abe2b5 View commit details
    Browse the repository at this point in the history

  7. test: use defineProperty for checking localStorage/sessionStorage acc… 

    …ess with createJSONStorage in server
    @mhsattarian
    mhsattarian committed May 29, 2024
    Configuration menu
    Copy the full SHA
    56d186a View commit details
    Browse the repository at this point in the history

  8. fix: ts error in new test

    @mhsattarian
    mhsattarian committed May 29, 2024
    Configuration menu
    Copy the full SHA
    f181938 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. improve detecting browser storage access in client

    @mhsattarian
    mhsattarian committed May 30, 2024
    Configuration menu
    Copy the full SHA
    a864f5d View commit details
    Browse the repository at this point in the history

  2. Update src/vanilla/utils/atomWithStorage.ts

    @dai-shi
    dai-shi authored May 30, 2024
    Configuration menu
    Copy the full SHA
    63be079 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. patch console.warn for atomWithStorage (in non-browser environment) test

    @mhsattarian
    mhsattarian committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    5728158 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix/createJSONStorage-subscribe

    @dai-shi
    dai-shi authored Jun 3, 2024
    Configuration menu
    Copy the full SHA
    982fd7c View commit details
    Browse the repository at this point in the history