Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canary 808.14 - importing animated from both /three and /web breaks #907

Closed
dbismut opened this issue Jan 20, 2020 · 5 comments
Closed

Canary 808.14 - importing animated from both /three and /web breaks #907

dbismut opened this issue Jan 20, 2020 · 5 comments
Labels
kind: bug Something isn't working
Milestone

Comments

@dbismut
Copy link
Contributor

dbismut commented Jan 20, 2020

🐛 Bug Report

For some reason, importing animated from react-spring/web and react-spring/three in the same project seems to break the animated component.

Link to repro

The following sandbox should make the content move when scrolling, which doesn't happen when line 3 of the sandbox is uncommented.

import { animated } from 'react-spring/three'

When looking at the style of the main element in the inspector it shows like the style property is reset to "" as soon as the user starts scrolling (ie modifying the spring).

Commenting / uncommenting line 3 activates / removes the bug.

https://codesandbox.io/s/polished-violet-0yzsm

Environment

  • react-spring v9 Canary 808.17
  • react v16.12.x
@dbismut dbismut added the kind: bug Something isn't working label Jan 20, 2020
@dbismut dbismut changed the title Canary 808.14 - importing animated from both /three and /web breaks shorthand style properties Canary 808.14 - importing animated from both /three and /web breaks Feb 19, 2020
@IngoValente
Copy link

Same problem here, title should maybe be updated to reflect that it's still broken in 808.17?

@beeglebug
Copy link

Also happens in 9.0.0-beta.34, can't animate dom and three in the same project, whichever is imported first is the only one which works

@aleclarson aleclarson added this to the v9.0.0 milestone May 3, 2020
@aleclarson
Copy link
Contributor

Fixed by #979

@aleclarson
Copy link
Contributor

Now available in v9.0.0-rc.2 #985

@dbismut
Copy link
Contributor Author

dbismut commented May 7, 2020

Indeed fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants