Fixes THREE.ColorManagement warning in r150 #2772
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9b8cdd2:
|
joshuaellis
reviewed
Feb 23, 2023
| @@ -286,7 +286,7 @@ function createRoot<TCanvas extends Element>(canvas: TCanvas): ReconcilerRoot<TC | |||
| // Safely set color management if available. | |||
| // Avoid accessing THREE.ColorManagement to play nice with older versions | |||
| if ('ColorManagement' in THREE) { | |||
| setDeep(THREE, legacy, ['ColorManagement', 'legacyMode']) | |||
| setDeep(THREE, !legacy, ['ColorManagement', 'enabled']) | |||
There was a problem hiding this comment.
wouldn't this therefore not work in r149 where the setting was different?
There was a problem hiding this comment.
I have a PR for that in #2620, will be cutting a release for these in a moment.
|
Continued in #2620 |
renovate bot
referenced
this pull request
in ziyadedher/ziyadedher
Feb 23, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@react-three/fiber](https://github.com/pmndrs/react-three-fiber) | [`8.11.2` -> `8.11.5`](https://renovatebot.com/diffs/npm/@react-three%2ffiber/8.11.2/8.11.5) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pmndrs/react-three-fiber</summary> ### [`v8.11.5`](https://github.com/pmndrs/react-three-fiber/releases/tag/v8.11.5) [Compare Source](https://github.com/pmndrs/react-three-fiber/compare/v8.11.4...v8.11.5) #### What's Changed - fix(types): update canvas root types by [@​CodyJasonBennett](https://github.com/CodyJasonBennett) in [https://github.com/pmndrs/react-three-fiber/pull/2774](https://github.com/pmndrs/react-three-fiber/pull/2774) **Full Changelog**: pmndrs/react-three-fiber@v8.11.4...v8.11.5 ### [`v8.11.4`](https://github.com/pmndrs/react-three-fiber/releases/tag/v8.11.4) [Compare Source](https://github.com/pmndrs/react-three-fiber/compare/v8.11.3...v8.11.4) #### What's Changed - fix: play nice with OffscreenCanvas by [@​CodyJasonBennett](https://github.com/CodyJasonBennett) in [https://github.com/pmndrs/react-three-fiber/pull/2770](https://github.com/pmndrs/react-three-fiber/pull/2770) - fix: use width and height from OffscreenCanvas by [@​ulyssesdotcodes](https://github.com/ulyssesdotcodes) in [https://github.com/pmndrs/react-three-fiber/pull/2773](https://github.com/pmndrs/react-three-fiber/pull/2773) **Full Changelog**: pmndrs/react-three-fiber@v8.11.3...v8.11.4 ### [`v8.11.3`](https://github.com/pmndrs/react-three-fiber/releases/tag/v8.11.3) [Compare Source](https://github.com/pmndrs/react-three-fiber/compare/v8.11.2...v8.11.3) #### What's Changed - fix(core): set THREE.ColorManagement.enabled if able by [@​CodyJasonBennett](https://github.com/CodyJasonBennett) in [https://github.com/pmndrs/react-three-fiber/pull/2620](https://github.com/pmndrs/react-three-fiber/pull/2620) - chore(docs): update documentation on re-using materials by [@​Coada](https://github.com/Coada) in [https://github.com/pmndrs/react-three-fiber/pull/2711](https://github.com/pmndrs/react-three-fiber/pull/2711) #### New Contributors - [@​Coada](https://github.com/Coada) made their first contribution in [https://github.com/pmndrs/react-three-fiber/pull/2711](https://github.com/pmndrs/react-three-fiber/pull/2711) - [@​enijar](https://github.com/enijar) made their first contribution in [https://github.com/pmndrs/react-three-fiber/pull/2772](https://github.com/pmndrs/react-three-fiber/pull/2772) **Full Changelog**: pmndrs/react-three-fiber@v8.11.2...v8.11.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ziyadedher/ziyadedher). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNDguMCIsInVwZGF0ZWRJblZlciI6IjM0LjE0OC4wIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
ziyadedher
referenced
this pull request
in ziyadedher/ziyadedher
Dec 16, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@react-three/fiber](https://github.com/pmndrs/react-three-fiber) | [`8.11.2` -> `8.11.5`](https://renovatebot.com/diffs/npm/@react-three%2ffiber/8.11.2/8.11.5) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pmndrs/react-three-fiber</summary> ### [`v8.11.5`](https://github.com/pmndrs/react-three-fiber/releases/tag/v8.11.5) [Compare Source](https://github.com/pmndrs/react-three-fiber/compare/v8.11.4...v8.11.5) #### What's Changed - fix(types): update canvas root types by [@​CodyJasonBennett](https://github.com/CodyJasonBennett) in [https://github.com/pmndrs/react-three-fiber/pull/2774](https://github.com/pmndrs/react-three-fiber/pull/2774) **Full Changelog**: pmndrs/react-three-fiber@v8.11.4...v8.11.5 ### [`v8.11.4`](https://github.com/pmndrs/react-three-fiber/releases/tag/v8.11.4) [Compare Source](https://github.com/pmndrs/react-three-fiber/compare/v8.11.3...v8.11.4) #### What's Changed - fix: play nice with OffscreenCanvas by [@​CodyJasonBennett](https://github.com/CodyJasonBennett) in [https://github.com/pmndrs/react-three-fiber/pull/2770](https://github.com/pmndrs/react-three-fiber/pull/2770) - fix: use width and height from OffscreenCanvas by [@​ulyssesdotcodes](https://github.com/ulyssesdotcodes) in [https://github.com/pmndrs/react-three-fiber/pull/2773](https://github.com/pmndrs/react-three-fiber/pull/2773) **Full Changelog**: pmndrs/react-three-fiber@v8.11.3...v8.11.4 ### [`v8.11.3`](https://github.com/pmndrs/react-three-fiber/releases/tag/v8.11.3) [Compare Source](https://github.com/pmndrs/react-three-fiber/compare/v8.11.2...v8.11.3) #### What's Changed - fix(core): set THREE.ColorManagement.enabled if able by [@​CodyJasonBennett](https://github.com/CodyJasonBennett) in [https://github.com/pmndrs/react-three-fiber/pull/2620](https://github.com/pmndrs/react-three-fiber/pull/2620) - chore(docs): update documentation on re-using materials by [@​Coada](https://github.com/Coada) in [https://github.com/pmndrs/react-three-fiber/pull/2711](https://github.com/pmndrs/react-three-fiber/pull/2711) #### New Contributors - [@​Coada](https://github.com/Coada) made their first contribution in [https://github.com/pmndrs/react-three-fiber/pull/2711](https://github.com/pmndrs/react-three-fiber/pull/2711) - [@​enijar](https://github.com/enijar) made their first contribution in [https://github.com/pmndrs/react-three-fiber/pull/2772](https://github.com/pmndrs/react-three-fiber/pull/2772) **Full Changelog**: pmndrs/react-three-fiber@v8.11.2...v8.11.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ziyadedher/ziyadedher). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNDguMCIsInVwZGF0ZWRJblZlciI6IjM0LjE0OC4wIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In three.js r150
THREE.ColorManagement.legacyMode = falsehas been replaced withTHREE.ColorManagement.enabled = true; this PR removes that warning message by updating the wayColorManagementis assigned based on thelegacyprop passed to the<Canvas />component.