fix: useMeasure to include safer orientation handling #3375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit dcef11f:
|
CodyJasonBennett
changed the title
|
I'll investigate testing this, but we should upstream and refresh |
CodyJasonBennett
changed the title
yukaorange
pushed a commit
to yukaorange/color-training-app
that referenced
this pull request
Oct 17, 2024
…ating 'screen.orientation.removeEventListener')」が発生、githubのissueにて、r3fにてscreen.orientのAPIを使用しているが、これが存在しないiphoneなんかでエラーになっている様子であった。解決策にしたがい、r3fをアップデートして、解決。pmndrs/react-three-fiber#3375
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version supported the latest screenOrientation API: https://developer.mozilla.org/en-US/docs/Web/API/ScreenOrientation
But of course iOS does not support this so was throwing errors.
This adds checks to make sure the objects exists and listeners can be added.
Falls back to depreciated method
orientationchangeon the window: https://developer.mozilla.org/en-US/docs/Web/API/Window/orientationchange_eventIf that doesn't exist either we have to pray the resize events correctly fire.
closes #3371