fix(KTX2Loader): web worker scope #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
🎉 This PR is included in version 2.30.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closed
This was referenced Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The web workers created by KTX2Loader throw the following error:
Uncaught ReferenceError: _KTX2Loader is not defined.This PR fixes that.
What
Updated the
BasisWorkerfunction to reference the variables that are prepended to the web worker code instead of referencing these values from theKTX2Loaderclass.Although the
BasisWorkerfunction is defined within theKTX2Loaderclass, once it's stringified and used as code for a web worker it doesn't have access anymore to its original upper scope. Therefore it will throw anReferenceError.JSDoc type annotations have been added to get the right type hinting in the
BasisWorkercode.Checklist
Fixes: