-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix typo in typescript.md #1152
Conversation
Not sure if `useBoundStore` had some special meaning in other places, but there were incorrect references to it in the `combine` comment that didn't match the example. (I just replaced it with `useBearStore` everywhere assuming it was a typo.)
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 73cb372:
|
|
Ah, ok, it may just need to be changed to |
Can you update the PR with your new suggestion? |
Done; now only the references that are actually incorrect have been updated. (Still feels weird to have both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The naming of useBoundStore
is pretty new in #1125. I'm not confident either. There might be a better idea, or just an education problem.
Not sure if
useBoundStore
had some special meaning in other places, but there were incorrect references to it in thecombine
comment that didn't match the example. (I just replaced it withuseBearStore
everywhere assuming it was a typo.)